Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: components/bookmarks/browser/bookmark_index_unittest.cc

Issue 489373005: Omnibox: Make URLs of Bookmarks Searchable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sky + pkasting's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bookmarks/browser/bookmark_index.cc ('k') | components/bookmarks/browser/bookmark_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bookmarks/browser/bookmark_index_unittest.cc
diff --git a/components/bookmarks/browser/bookmark_index_unittest.cc b/components/bookmarks/browser/bookmark_index_unittest.cc
index e588217322faabad29522440011d6689c9c3d364..3898e59299e7f70c08ad7b0d2f1a384ae1c6c813 100644
--- a/components/bookmarks/browser/bookmark_index_unittest.cc
+++ b/components/bookmarks/browser/bookmark_index_unittest.cc
@@ -55,7 +55,7 @@ class BookmarkClientMock : public test::TestBookmarkClient {
class BookmarkIndexTest : public testing::Test {
public:
- BookmarkIndexTest() : model_(client_.CreateModel(false)) {}
+ BookmarkIndexTest() : model_(client_.CreateModel()) {}
typedef std::pair<std::string, std::string> TitleAndURL;
@@ -189,7 +189,7 @@ TEST_F(BookmarkIndexTest, GetBookmarksMatching) {
ExpectMatches(data[i].query, expected);
- model_ = client_.CreateModel(false);
+ model_ = client_.CreateModel();
}
}
@@ -238,7 +238,7 @@ TEST_F(BookmarkIndexTest, GetBookmarksMatchingWithURLs) {
};
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i) {
- model_ = client_.CreateModel(true);
+ model_ = client_.CreateModel();
std::vector<TitleAndURL> bookmarks;
bookmarks.push_back(TitleAndURL(data[i].title, data[i].url));
AddBookmarks(bookmarks);
@@ -275,7 +275,7 @@ TEST_F(BookmarkIndexTest, Normalization) {
std::vector<BookmarkMatch> matches;
model_->GetBookmarksMatching(UTF8ToUTF16(data[i].query), 10, &matches);
EXPECT_EQ(1u, matches.size());
- model_ = client_.CreateModel(false);
+ model_ = client_.CreateModel();
}
}
@@ -312,7 +312,7 @@ TEST_F(BookmarkIndexTest, MatchPositionsTitles) {
ExpectMatchPositions(matches[0].title_match_positions,
expected_title_matches);
- model_ = client_.CreateModel(false);
+ model_ = client_.CreateModel();
}
}
@@ -348,7 +348,7 @@ TEST_F(BookmarkIndexTest, MatchPositionsURLs) {
};
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i) {
- model_ = client_.CreateModel(true);
+ model_ = client_.CreateModel();
std::vector<TitleAndURL> bookmarks;
TitleAndURL bookmark("123456", data[i].url);
bookmarks.push_back(bookmark);
@@ -430,7 +430,7 @@ TEST_F(BookmarkIndexTest, GetResultsSortedByTypedCount) {
typed_count_map.insert(std::make_pair(data[i].url, data[i].typed_count));
BookmarkClientMock client(typed_count_map);
- scoped_ptr<BookmarkModel> model = client.CreateModel(false);
+ scoped_ptr<BookmarkModel> model = client.CreateModel();
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(data); ++i)
// Populate the BookmarkIndex.
« no previous file with comments | « components/bookmarks/browser/bookmark_index.cc ('k') | components/bookmarks/browser/bookmark_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698