Omnibox: Make URLs of Bookmarks Searchable

Omnibox: Make URLs of Bookmarks Searchable

This used to be controlled by a field trial created in
https://codereview.chromium.org/184663002

After evaluating this change, we've decided to launch it.
This change turns the flag on by default and removes the field trial code.
It also removes the index_urls_ parameters everywhere because those will
always be true forevermore.

I tested this interactively.
Also, all the unit tests still apparently pass.  And yes some of these do
exercise this feature.

TBR=joaodasilva
(for trivial change to components/policy/core/browser/managed_bookmarks_tracker_unittest.cc )

BUG=157204, 378854
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291445

[Mark P, 2014-08-21 23:33:11]

Peter & Scott,

This is mostly just an interface change; it should be straightforward to review.

Please take a look.

thanks,
mark

https://codereview.chromium.org/489373005/diff/1/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/bookmark_provider_unittest.cc (right):

https://codereview.chromium.org/489373005/diff/1/chrome/browser/autocomplete/...
chrome/browser/autocomplete/bookmark_provider_unittest.cc:37: { "a definition",
"http://www.catsanddogs.com/e" },
Swapped order of titles without changing URLs.  (There's a search for "a d"
below that was getting an errant match with the "d" in the URL path and the "a"
in "a definition.)

[sky, 2014-08-21 23:56:04]

LGTM

https://codereview.chromium.org/489373005/diff/1/components/bookmarks/browser...
File components/bookmarks/browser/bookmark_model.h (right):

https://codereview.chromium.org/489373005/diff/1/components/bookmarks/browser...
components/bookmarks/browser/bookmark_model.h:69:
BookmarkModel(bookmarks::BookmarkClient* client);
explicit

[Peter Kasting, 2014-08-22 00:31:22]

LGTM

https://codereview.chromium.org/489373005/diff/1/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/bookmark_provider.cc (right):

https://codereview.chromium.org/489373005/diff/1/chrome/browser/autocomplete/...
chrome/browser/autocomplete/bookmark_provider.cc:233: // between these
high-quality bookmarks.)
Nit: Closing paren does not have matching open paren

https://codereview.chromium.org/489373005/diff/1/components/bookmarks/browser...
File components/bookmarks/browser/bookmark_index.h (right):

https://codereview.chromium.org/489373005/diff/1/components/bookmarks/browser...
components/bookmarks/browser/bookmark_index.h:33: // |languages| used to help
parse IDNs in URLs for the bookmark index.
Nit: is used

[Mark P, 2014-08-22 15:56:39]

https://codereview.chromium.org/489373005/diff/1/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/bookmark_provider.cc (right):

https://codereview.chromium.org/489373005/diff/1/chrome/browser/autocomplete/...
chrome/browser/autocomplete/bookmark_provider.cc:233: // between these
high-quality bookmarks.)
On 2014/08/22 00:31:22, Peter Kasting wrote:
> Nit: Closing paren does not have matching open paren

Done.

https://codereview.chromium.org/489373005/diff/1/components/bookmarks/browser...
File components/bookmarks/browser/bookmark_index.h (right):

https://codereview.chromium.org/489373005/diff/1/components/bookmarks/browser...
components/bookmarks/browser/bookmark_index.h:33: // |languages| used to help
parse IDNs in URLs for the bookmark index.
On 2014/08/22 00:31:22, Peter Kasting wrote:
> Nit: is used

Done.

https://codereview.chromium.org/489373005/diff/1/components/bookmarks/browser...
File components/bookmarks/browser/bookmark_model.h (right):

https://codereview.chromium.org/489373005/diff/1/components/bookmarks/browser...
components/bookmarks/browser/bookmark_model.h:69:
BookmarkModel(bookmarks::BookmarkClient* client);
On 2014/08/21 23:56:04, sky wrote:
> explicit

Done.

[Mark P, 2014-08-22 15:56:44]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-08-22 15:57:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpearson@chromium.org/489373005/20001

[commit-bot: I haz the power, 2014-08-22 17:40:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-22 17:44:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 17:44:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mark P, 2014-08-22 17:47:36]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-08-22 17:48:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpearson@chromium.org/489373005/20001

[commit-bot: I haz the power, 2014-08-22 18:05:33]

Committed patchset #2 (20001) as 291445

[Evan Stade, 2014-08-22 20:35:10]

A revert of this CL (patchset #2) has been created in
https://codereview.chromium.org/485483003/ by estade@chromium.org.

The reason for reverting is: Broke interactive_ui_tests on mac:
https://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20(dbg)....