Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489373002: Fix spelling of provideNotificationPermissionClientTo() (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix spelling of provideNotificationPermissionClientTo() TBR=tkent NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/modules/notifications/NotificationPermissionClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/NotificationPermissionClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-21 12:01:10 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-21 12:25:34 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-21 12:34:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/489373002/1
6 years, 4 months ago (2014-08-21 12:35:15 UTC) #4
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-21 14:34:37 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-21 14:42:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/489373002/1
6 years, 4 months ago (2014-08-21 14:43:43 UTC) #7
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-21 15:09:47 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-21 15:17:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/489373002/1
6 years, 4 months ago (2014-08-21 15:18:51 UTC) #10
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-21 18:31:23 UTC) #11
sof
tkent@: Source/web/ rubberstamp, please? :)
6 years, 4 months ago (2014-08-21 18:33:59 UTC) #12
haraken
tkent-san is ooo today. I think you can TBR for this kind of trivial change ...
6 years, 4 months ago (2014-08-21 23:55:05 UTC) #13
sof
On 2014/08/21 23:55:05, haraken wrote: > tkent-san is ooo today. I think you can TBR ...
6 years, 4 months ago (2014-08-22 05:00:25 UTC) #14
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-22 05:00:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/489373002/1
6 years, 4 months ago (2014-08-22 05:01:11 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 05:01:38 UTC) #17
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180755

Powered by Google App Engine
This is Rietveld 408576698