components/omnibox/base_search_provider.cc - Issue 489353004: Componentize SearchProvider

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/omnibox/base_search_provider.cc

Issue 489353004: Componentize SearchProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/omnibox/base_search_provider.h ('k') | components/omnibox/search_provider.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/autocomplete/base_search_provider.h"	5 #include "components/omnibox/base_search_provider.h"

6	6

7 #include "base/i18n/case_conversion.h"	7 #include "base/i18n/case_conversion.h"

8 #include "base/strings/string_util.h"	8 #include "base/strings/string_util.h"

9 #include "base/strings/utf_string_conversions.h"	9 #include "base/strings/utf_string_conversions.h"

10 #include "components/metrics/proto/omnibox_event.pb.h"	10 #include "components/metrics/proto/omnibox_event.pb.h"

11 #include "components/metrics/proto/omnibox_input_type.pb.h"	11 #include "components/metrics/proto/omnibox_input_type.pb.h"

12 #include "components/omnibox/autocomplete_provider_delegate.h"	12 #include "components/omnibox/autocomplete_provider_delegate.h"

13 #include "components/omnibox/autocomplete_provider_listener.h"	13 #include "components/omnibox/autocomplete_provider_listener.h"

14 #include "components/omnibox/omnibox_field_trial.h"	14 #include "components/omnibox/omnibox_field_trial.h"

15 #include "components/search_engines/template_url.h"	15 #include "components/search_engines/template_url.h"

(...skipping 438 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
454 }	454 }

455	455

456 void BaseSearchProvider::OnDeletionComplete(	456 void BaseSearchProvider::OnDeletionComplete(

457 bool success, SuggestionDeletionHandler* handler) {	457 bool success, SuggestionDeletionHandler* handler) {

458 RecordDeletionResult(success);	458 RecordDeletionResult(success);

459 SuggestionDeletionHandlers::iterator it = std::find(	459 SuggestionDeletionHandlers::iterator it = std::find(

460 deletion_handlers_.begin(), deletion_handlers_.end(), handler);	460 deletion_handlers_.begin(), deletion_handlers_.end(), handler);

461 DCHECK(it != deletion_handlers_.end());	461 DCHECK(it != deletion_handlers_.end());

462 deletion_handlers_.erase(it);	462 deletion_handlers_.erase(it);

463 }	463 }

OLD	NEW