Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489353004: Componentize SearchProvider (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 3 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Componentize SearchProvider Move BaseSearchProvider, SearchProvider, AnswersCache to components/omnibox BUG=388515 TBR=bauerb@chromium.org for include fix in chrome/browser/android/omnibox/autocomplete_controller_android.cc Committed: https://crrev.com/5f7db4b3d417c7ae556c42d8e13d0c1ac64415f8 Cr-Commit-Position: refs/heads/master@{#292085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2586 lines) Patch
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/autocomplete/answers_cache.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/autocomplete/answers_cache.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/autocomplete/answers_cache_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/autocomplete/base_search_provider.h View 1 chunk +0 lines, -257 lines 0 comments Download
D chrome/browser/autocomplete/base_search_provider.cc View 1 chunk +0 lines, -463 lines 0 comments Download
D chrome/browser/autocomplete/search_provider.h View 1 chunk +0 lines, -367 lines 0 comments Download
D chrome/browser/autocomplete/search_provider.cc View 1 chunk +0 lines, -1256 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox.gypi View 3 chunks +6 lines, -0 lines 0 comments Download
M components/omnibox/BUILD.gn View 4 chunks +7 lines, -0 lines 0 comments Download
A + components/omnibox/answers_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/answers_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/omnibox/answers_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/omnibox/base_search_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/base_search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/omnibox/search_provider.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/omnibox/search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
hashimoto
hashimoto@chromium.org changed reviewers: + pkasting@chromium.org
6 years, 4 months ago (2014-08-26 08:50:00 UTC) #1
hashimoto
6 years, 4 months ago (2014-08-26 08:50:00 UTC) #2
Peter Kasting
LGTM
6 years, 3 months ago (2014-08-26 17:58:26 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 3 months ago (2014-08-27 01:47:45 UTC) #4
hashimoto
The CQ bit was unchecked by hashimoto@chromium.org
6 years, 3 months ago (2014-08-27 01:47:54 UTC) #5
hashimoto
hashimoto@chromium.org changed reviewers: + bauerb@chromium.org
6 years, 3 months ago (2014-08-27 01:49:10 UTC) #6
hashimoto
TBRing bauerb@chromium.org for include fix in chrome/browser/android/omnibox/autocomplete_controller_android.cc
6 years, 3 months ago (2014-08-27 01:49:25 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 3 months ago (2014-08-27 01:49:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/489353004/1
6 years, 3 months ago (2014-08-27 01:50:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as ed99d29e96cad969939f64773c21426b261904f7
6 years, 3 months ago (2014-08-27 02:46:35 UTC) #10
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-08-27 08:18:02 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:19 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5f7db4b3d417c7ae556c42d8e13d0c1ac64415f8
Cr-Commit-Position: refs/heads/master@{#292085}

Powered by Google App Engine
This is Rietveld 408576698