Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 489353003: ThreadSafeRefCountedGarbageCollected should use makeKeepAlive (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium)
Project:
blink
Visibility:
Public.

Description

ThreadSafeRefCountedGarbageCollected should use makeKeepAlive Similar to RefCountedGarbageCollected, ThreadSafeRefCountedGarbageCollected should use a helper method to create a self-keep-alive handle. This change is to make it easier to blacklist a bad cast detected in UBSan. BUG=405345 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/platform/heap/Heap.h View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
haraken
PTAL
6 years, 4 months ago (2014-08-22 00:05:11 UTC) #1
haraken
6 years, 4 months ago (2014-08-22 00:07:36 UTC) #2
inferno
The CQ bit was checked by inferno@chromium.org
6 years, 4 months ago (2014-08-22 04:48:36 UTC) #3
inferno
lgtm
6 years, 4 months ago (2014-08-22 04:48:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/489353003/1
6 years, 4 months ago (2014-08-22 04:49:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 05:48:27 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:50:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8209)
6 years, 4 months ago (2014-08-22 05:50:58 UTC) #8
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 4 months ago (2014-08-22 06:00:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/489353003/1
6 years, 4 months ago (2014-08-22 06:00:37 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 06:01:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 180756

Powered by Google App Engine
This is Rietveld 408576698