Disable sync in EphemeralAppBrowserTests on Windows due to flakiness

Disable sync in EphemeralAppBrowserTests on Windows due to flakiness

BUG=401028
TEST=browser_tests

Committed: https://crrev.com/94a526a13585f1024458aabfd36457221800d5e6
Cr-Commit-Position: refs/heads/master@{#291845}

[tmdiep, 2014-08-22 02:37:29]

Disabling the sync portion of these tests for Windows. It seems as though chrome
is attempting to sync the apps with the backend.

[benwells, 2014-08-26 03:09:55]

https://codereview.chromium.org/489333002/diff/1/chrome/browser/apps/ephemera...
File chrome/browser/apps/ephemeral_app_browsertest.cc (right):

https://codereview.chromium.org/489333002/diff/1/chrome/browser/apps/ephemera...
chrome/browser/apps/ephemeral_app_browsertest.cc:65: // everything else can be
tested. See crbug.com/401028
This makes me a bit uneasy. Is there some underlying problem that we're
ignoring?

[tmdiep, 2014-08-26 03:44:45]

https://codereview.chromium.org/489333002/diff/1/chrome/browser/apps/ephemera...
File chrome/browser/apps/ephemeral_app_browsertest.cc (right):

https://codereview.chromium.org/489333002/diff/1/chrome/browser/apps/ephemera...
chrome/browser/apps/ephemeral_app_browsertest.cc:65: // everything else can be
tested. See crbug.com/401028
On 2014/08/26 03:09:54, benwells wrote:
> This makes me a bit uneasy. Is there some underlying problem that we're
> ignoring?

Yes.
This patch is intended to be a temporary bandaid as I know more of these tests
are flaky, but not yet disabled. I'm leaving the bug open to fix the actual
problem later.

[benwells, 2014-08-26 03:58:13]

lgtm

https://codereview.chromium.org/489333002/diff/1/chrome/browser/apps/ephemera...
File chrome/browser/apps/ephemeral_app_browsertest.cc (right):

https://codereview.chromium.org/489333002/diff/1/chrome/browser/apps/ephemera...
chrome/browser/apps/ephemeral_app_browsertest.cc:65: // everything else can be
tested. See crbug.com/401028
On 2014/08/26 03:44:45, tmdiep wrote:
> On 2014/08/26 03:09:54, benwells wrote:
> > This makes me a bit uneasy. Is there some underlying problem that we're
> > ignoring?
> 
> Yes.
> This patch is intended to be a temporary bandaid as I know more of these tests
> are flaky, but not yet disabled. I'm leaving the bug open to fix the actual
> problem later.

OK. It is probably that someone else that should be looking at the underlying
problem. Is it ephemeral app or sync related?

[tmdiep, 2014-08-26 04:29:40]

https://codereview.chromium.org/489333002/diff/1/chrome/browser/apps/ephemera...
File chrome/browser/apps/ephemeral_app_browsertest.cc (right):

https://codereview.chromium.org/489333002/diff/1/chrome/browser/apps/ephemera...
chrome/browser/apps/ephemeral_app_browsertest.cc:65: // everything else can be
tested. See crbug.com/401028
On 2014/08/26 03:58:12, benwells wrote:
> OK. It is probably that someone else that should be looking at the underlying
> problem. Is it ephemeral app or sync related?

I think it's sync related. There are other browser tests that have tried to
enable sync, but have also been disabled due to flakiness (setting_apitest.cc).
I'm not sure whether it's due to the same problem, haven't had the chance to
investigate.

We probably just need to mock something in tests.

[tmdiep, 2014-08-26 04:30:12]

The CQ bit was checked by tmdiep@chromium.org

[commit-bot: I haz the power, 2014-08-26 04:30:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tmdiep@chromium.org/489333002/1

[commit-bot: I haz the power, 2014-08-26 05:24:14]

Committed patchset #1 (1) as 97b704e88d066d0666b12706cf021a2ee00bd1cf

[commit-bot: I haz the power, 2014-09-10 02:40:39]

Patchset 1 (id:??) landed as
https://crrev.com/94a526a13585f1024458aabfd36457221800d5e6
Cr-Commit-Position: refs/heads/master@{#291845}