Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 489213003: Prevent double acking of ignored touches (Closed)

Created:
6 years, 4 months ago by tdresser
Modified:
6 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Previously our handling of ignored touches would put the gesture recognizer into a very confused state. BUG=405519 TEST=GestureRecognizerTest.IgnoredEventsDontPreventFutureEvents Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291255

Patch Set 1 #

Patch Set 2 : Switch to calling StopPropagation on ignored events. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tdresser
Sadrul, can you take a look? This fixes similar issues across a few other platforms, ...
6 years, 4 months ago (2014-08-21 16:47:24 UTC) #1
sadrul
lgtm
6 years, 4 months ago (2014-08-21 18:54:42 UTC) #2
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 4 months ago (2014-08-21 18:59:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/489213003/40001
6 years, 4 months ago (2014-08-21 19:00:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 21:51:11 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:59:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (40001) as 291255

Powered by Google App Engine
This is Rietveld 408576698