|
|
Created:
6 years, 4 months ago by jamesr Modified:
6 years, 4 months ago Reviewers:
yzshen1 CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
DescriptionMark optional mojo quads fields as nullable
These fields are intended to all be null but one, so annotate them all
as nullable in the mojom so the validator is happy.
NOTRY=true
(linux_gpu bot is down due to infra problem, passes everything else)
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290945
Patch Set 1 #
Messages
Total messages: 19 (0 generated)
lgtm
The CQ bit was checked by jamesr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/489213002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was checked by jamesr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/489213002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
The CQ bit was checked by jamesr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/489213002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
The CQ bit was unchecked by jamesr@chromium.org
The CQ bit was checked by jamesr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/489213002/1
Message was sent while issue was closed.
Committed patchset #1 (1) as 290945 |