Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 489213002: Mark optional mojo quads fields as nullable (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mark optional mojo quads fields as nullable These fields are intended to all be null but one, so annotate them all as nullable in the mojom so the validator is happy. NOTRY=true (linux_gpu bot is down due to infra problem, passes everything else) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M mojo/services/public/interfaces/surfaces/quads.mojom View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
jamesr
6 years, 4 months ago (2014-08-20 19:25:50 UTC) #1
yzshen1
lgtm
6 years, 4 months ago (2014-08-20 19:29:03 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-20 19:39:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/489213002/1
6 years, 4 months ago (2014-08-20 19:40:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 20:52:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 20:55:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55073) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/7888)
6 years, 4 months ago (2014-08-20 20:55:22 UTC) #7
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-20 20:58:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/489213002/1
6 years, 4 months ago (2014-08-20 21:00:23 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 21:50:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 21:54:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55148)
6 years, 4 months ago (2014-08-20 21:54:12 UTC) #12
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-20 23:07:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/489213002/1
6 years, 4 months ago (2014-08-20 23:10:32 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 23:15:14 UTC) #15
jamesr
The CQ bit was unchecked by jamesr@chromium.org
6 years, 4 months ago (2014-08-20 23:15:48 UTC) #16
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-20 23:15:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/489213002/1
6 years, 4 months ago (2014-08-20 23:17:48 UTC) #18
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 23:20:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (1) as 290945

Powered by Google App Engine
This is Rietveld 408576698