Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4812)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view.cc

Issue 489183005: Make a ShowExtensionActionPopup function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Peter's Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_view.h ('k') | chrome/test/base/test_browser_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc
index 92791c5cab86add4e901222e52f3a77de4b37625..573795fccd7857eeda603eeecd07b73870235446 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc
@@ -14,8 +14,6 @@
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/command_updater.h"
-#include "chrome/browser/extensions/extension_action.h"
-#include "chrome/browser/extensions/extension_action_manager.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/themes/theme_service.h"
@@ -319,22 +317,6 @@ void ToolbarView::ExecuteExtensionCommand(
browser_actions_->ExecuteExtensionCommand(extension, command);
}
-void ToolbarView::ShowPageActionPopup(const extensions::Extension* extension) {
- extensions::ExtensionActionManager* extension_manager =
- extensions::ExtensionActionManager::Get(browser_->profile());
- ExtensionAction* extension_action =
- extension_manager->GetPageAction(*extension);
- if (extension_action) {
- location_bar_->GetPageActionView(extension_action)->image_view()->
- view_controller()->ExecuteAction(ExtensionPopup::SHOW, false);
- }
-}
-
-void ToolbarView::ShowBrowserActionPopup(
- const extensions::Extension* extension) {
- browser_actions_->ShowPopupForExtension(extension, true, false);
-}
-
void ToolbarView::ShowAppMenu(bool for_drop) {
if (wrench_menu_.get() && wrench_menu_->IsShowing())
return;
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_view.h ('k') | chrome/test/base/test_browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698