Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 489183005: Make a ShowExtensionActionPopup function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Peter's Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 5024cf8e4ea5f917c1d112c83d4a0d1cd7866eff..880f6e8adf69af76bec3fa32f86c0ddd61b4a09d 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -402,15 +402,6 @@ class BrowserWindow : public ui::BaseWindow {
virtual void ExecuteExtensionCommand(const extensions::Extension* extension,
const extensions::Command& command) = 0;
- // Shows the page action for the extension.
- virtual void ShowPageActionPopup(const extensions::Extension* extension) = 0;
-
- // Shows the browser action for the extension. NOTE(wittman): This function
- // grants tab permissions to the browser action popup, so it should only be
- // invoked due to user action, not due to invocation from an extensions API.
- virtual void ShowBrowserActionPopup(
- const extensions::Extension* extension) = 0;
-
protected:
friend class BrowserCloseManager;
friend class BrowserView;
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698