media/video/capture/win/video_capture_device_mf_win.cc - Issue 489183003: Log error messages in windows video capture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/win/video_capture_device_mf_win.cc

Issue 489183003: Log error messages in windows video capture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: syntax error : missing ')' Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/capture/win/video_capture_device_mf_win.cc

diff --git a/media/video/capture/win/video_capture_device_mf_win.cc b/media/video/capture/win/video_capture_device_mf_win.cc

index de1f6eb2dfff6056305637b94937a86eedae0b95..ab945a237e6168c5ac580026ae0acabf9fcb056c 100644

--- a/media/video/capture/win/video_capture_device_mf_win.cc

+++ b/media/video/capture/win/video_capture_device_mf_win.cc

@@ -332,10 +332,10 @@ void VideoCaptureDeviceMFWin::OnIncomingCapturedData(

}

void VideoCaptureDeviceMFWin::OnError(HRESULT hr) {

- std::string log_msg = base::StringPrintf("VideoCaptureDeviceMFWin: %x", hr);

- DLOG(ERROR) << log_msg;

if (client_.get())

tommi (sloooow) - chröme 2014/08/30 17:39:33 since the body of the if() contains more than one

magjed_chromium 2014/09/01 08:34:14 Done.

- client_->OnError(log_msg);

+ client_->OnError(

+ base::StringPrintf("VideoCaptureDeviceMFWin: %s",

+ logging::SystemErrorCodeToString(hr).c_str()));

}

} // namespace media