Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 489143003: Fix manpage creation error. (Closed)

Created:
6 years, 4 months ago by Michael Moss
Modified:
6 years, 4 months ago
Reviewers:
iannucci1, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, smut
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Fix manpage creation error. When running make_docs.sh, I get the error: asciidoc: FAILED: manpage document title is mandatory make: *** [git-cherry-pick-upload.xml] Error 1 I don't fully understand why, or why this hasn't come up before, but it seems to be complaining about the formatting of "===" in git-cherry-pick-upload.txt. This was with xmlto version 0.0.25 on Precise. R=iannucci@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=290939

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M man/html/git-cherry-pick-upload.html View 2 chunks +2 lines, -2 lines 0 comments Download
M man/man1/git-cherry-pick-upload.1 View 4 chunks +7 lines, -7 lines 0 comments Download
M man/src/git-cherry-pick-upload.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Moss
6 years, 4 months ago (2014-08-20 16:42:57 UTC) #1
iannucci
lgtm, not sure how that happend
6 years, 4 months ago (2014-08-20 18:57:32 UTC) #2
iannucci
On 2014/08/20 18:57:32, iannucci wrote: > lgtm, not sure how that happend (also, please run ...
6 years, 4 months ago (2014-08-20 18:59:35 UTC) #3
Michael Moss
The CQ bit was checked by mmoss@chromium.org
6 years, 4 months ago (2014-08-20 22:50:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmoss@chromium.org/489143003/20001
6 years, 4 months ago (2014-08-20 22:51:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (20001) as 290939
6 years, 4 months ago (2014-08-20 22:54:18 UTC) #6
Michael Moss
6 years, 4 months ago (2014-08-20 23:31:46 UTC) #7
Message was sent while issue was closed.
> (also, please run depot_tools/man/push_to_gs.sh when this lands to update
>
https://storage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/d...)

Done.

Powered by Google App Engine
This is Rietveld 408576698