Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489113003: Remove MutableProfileOAuth2TokenService on iOS. (Closed)

Created:
6 years, 4 months ago by msarda
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove MutableProfileOAuth2TokenService on iOS. Shared Authentication is the only supported scheme starting with M39. This CL removes the dependency on MutableProfileOAuth2TokenService on iOS. BUG=233117 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291189

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revert changes in fake_profile_oauth2_token_service.h #

Patch Set 3 : Move DCHECK. #

Patch Set 4 : Remove DCHECK(getter). #

Messages

Total messages: 36 (0 generated)
msarda
Please take a look.
6 years, 4 months ago (2014-08-20 15:26:16 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm, with one comment below. Nice cleanup! https://codereview.chromium.org/489113003/diff/1/chrome/browser/signin/fake_profile_oauth2_token_service.h File chrome/browser/signin/fake_profile_oauth2_token_service.h (right): https://codereview.chromium.org/489113003/diff/1/chrome/browser/signin/fake_profile_oauth2_token_service.h#newcode145 chrome/browser/signin/fake_profile_oauth2_token_service.h:145: #endif Don't ...
6 years, 4 months ago (2014-08-20 15:43:57 UTC) #2
sdefresne
https://codereview.chromium.org/489113003/diff/1/components/signin/ios/browser/profile_oauth2_token_service_ios.h File components/signin/ios/browser/profile_oauth2_token_service_ios.h (right): https://codereview.chromium.org/489113003/diff/1/components/signin/ios/browser/profile_oauth2_token_service_ios.h#newcode119 components/signin/ios/browser/profile_oauth2_token_service_ios.h:119: // ProfileOAuth2TokenService from multiple threads in upstream code. s/upstream/common/?
6 years, 4 months ago (2014-08-20 15:45:55 UTC) #3
sdefresne
-rohitaro, +rohitrao
6 years, 4 months ago (2014-08-20 15:46:23 UTC) #4
msarda
Rohit: Please take a look at the changes in ios/
6 years, 4 months ago (2014-08-20 15:47:01 UTC) #5
rohitrao (ping after 24h)
lgtm
6 years, 4 months ago (2014-08-20 15:48:39 UTC) #6
msarda
Erik: Please take a look at top-level changes in components/.
6 years, 4 months ago (2014-08-20 15:48:40 UTC) #7
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 4 months ago (2014-08-20 15:49:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/489113003/20001
6 years, 4 months ago (2014-08-20 15:49:59 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 17:14:24 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 17:52:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/6109)
6 years, 4 months ago (2014-08-20 17:52:04 UTC) #12
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 4 months ago (2014-08-20 18:27:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/489113003/20001
6 years, 4 months ago (2014-08-20 18:28:54 UTC) #14
msarda
The CQ bit was unchecked by msarda@chromium.org
6 years, 4 months ago (2014-08-20 18:29:18 UTC) #15
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 4 months ago (2014-08-20 18:29:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/489113003/20001
6 years, 4 months ago (2014-08-20 18:31:50 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 19:45:40 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 20:27:56 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/6193)
6 years, 4 months ago (2014-08-20 20:27:57 UTC) #20
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 4 months ago (2014-08-21 07:47:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/489113003/20001
6 years, 4 months ago (2014-08-21 07:48:05 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 08:26:01 UTC) #23
msarda
I had to move a DCHECK as it fails tests on linux_chromium_chromeos_rel_swarming.
6 years, 4 months ago (2014-08-21 12:21:31 UTC) #24
msarda
I had to move a DCHECK as it fails tests on linux_chromium_chromeos_rel_swarming.
6 years, 4 months ago (2014-08-21 12:21:31 UTC) #25
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 4 months ago (2014-08-21 12:21:49 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/489113003/40001
6 years, 4 months ago (2014-08-21 12:22:28 UTC) #27
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 4 months ago (2014-08-21 13:22:15 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/489113003/60001
6 years, 4 months ago (2014-08-21 13:22:33 UTC) #29
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 14:49:30 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 15:40:36 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/978)
6 years, 4 months ago (2014-08-21 15:40:37 UTC) #32
msarda
The CQ bit was checked by msarda@chromium.org
6 years, 4 months ago (2014-08-21 16:51:41 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msarda@chromium.org/489113003/60001
6 years, 4 months ago (2014-08-21 16:53:12 UTC) #34
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 20:50:02 UTC) #35
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:25:39 UTC) #36
Message was sent while issue was closed. 
Committed patchset #4 (60001) as 291189

Powered by Google App Engine
This is Rietveld 408576698