Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3242)

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.h

Issue 489103004: Allow editing passwords in settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added one more test. Modified the comments and the string. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/password_manager_handler.h
diff --git a/chrome/browser/ui/webui/options/password_manager_handler.h b/chrome/browser/ui/webui/options/password_manager_handler.h
index bae096bcbfc32b7f847e5adb06b720b6337b48fd..c60687454221ac3b82ca47ccc959f6fd046fdd66 100644
--- a/chrome/browser/ui/webui/options/password_manager_handler.h
+++ b/chrome/browser/ui/webui/options/password_manager_handler.h
@@ -46,6 +46,17 @@ class PasswordManagerHandler : public OptionsPageUIHandler,
// Called when the JS PasswordManager object is initialized.
void HandleUpdatePasswordLists(const base::ListValue* args);
+ // Checks if |origin| is valid for adding a new entry. Called while the user
Dan Beam 2014/08/26 17:39:07 nit: 1 \s between sentences
jaekyeom 2014/08/27 12:28:54 Done. However I've wanted to know if there is a gu
+ // is editing an origin.
+ void HandleCheckOriginValidityForAdding(const base::ListValue* args);
+
+ // Adds a new password entry with |origin|, |username_value|, and
+ // |password_value|.
+ void HandleAddPassword(const base::ListValue* args);
+
+ // Updates the entry at |index| with |password_value|.
+ void HandleUpdatePassword(const base::ListValue* args);
+
// Removes a saved password entry.
// |value| the entry index to be removed.
void HandleRemoveSavedPassword(const base::ListValue* args);

Powered by Google App Engine
This is Rietveld 408576698