Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3440)

Unified Diff: chrome/browser/ui/passwords/password_manager_presenter.h

Issue 489103004: Allow editing passwords in settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a type mismatch in password_manager.js Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/password_manager_presenter.h
diff --git a/chrome/browser/ui/passwords/password_manager_presenter.h b/chrome/browser/ui/passwords/password_manager_presenter.h
index 66c68462967c25cc4689f18f2bad21fa34f7e568..82095cfa3adfa6d29a17ffaaeac46f8cf63f591c 100644
--- a/chrome/browser/ui/passwords/password_manager_presenter.h
+++ b/chrome/browser/ui/passwords/password_manager_presenter.h
@@ -5,22 +5,24 @@
#ifndef CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_
#define CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_
+#include <stddef.h>
#include <string>
#include <vector>
#include "base/memory/scoped_vector.h"
#include "base/prefs/pref_member.h"
+#include "base/strings/string16.h"
#include "components/password_manager/core/browser/password_store.h"
#include "components/password_manager/core/browser/password_store_consumer.h"
+class GURL;
+class PasswordUIView;
+class Profile;
+
namespace autofill {
struct PasswordForm;
}
-class PasswordUIView;
-
-class Profile;
-
// Contains the common logic used by a PasswordUIView to
// interact with PasswordStore. It provides completion callbacks for
// PasswordStore operations and updates the view on PasswordStore changes.
@@ -31,6 +33,9 @@ class PasswordManagerPresenter
explicit PasswordManagerPresenter(PasswordUIView* password_view);
virtual ~PasswordManagerPresenter();
+ // Checks if |origin| is valid for adding a new password entry.
+ static bool CheckOriginValidityForAdding(const GURL& origin);
+
// PasswordStore::Observer implementation.
virtual void OnLoginsChanged(
const password_manager::PasswordStoreChangeList& changes) OVERRIDE;
@@ -46,6 +51,17 @@ class PasswordManagerPresenter
// Gets the password exception entry at |index|.
const autofill::PasswordForm* GetPasswordException(size_t index);
+ // Adds a new password entry with |origin|, |username_value|, and
+ // |password_value|. |origin| should have been validated by
+ // CheckOriginValidityForAdding, and |password_value| should be non-empty.
+ void AddPassword(const GURL& origin,
+ const base::string16& username_value,
+ const base::string16& password_value);
+
+ // Updates the entry at |index| with |password_value|. |password_value| should
+ // be non-empty.
+ void UpdatePassword(size_t index, const base::string16& password_value);
+
// Removes the saved password entry at |index|.
// |index| the entry index to be removed.
void RemoveSavedPassword(size_t index);
« no previous file with comments | « chrome/browser/resources/options/password_manager_list.js ('k') | chrome/browser/ui/passwords/password_manager_presenter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698