Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4388)

Unified Diff: chrome/browser/ui/passwords/password_manager_presenter.h

Issue 489103004: Allow editing passwords in settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: It supports overwriting and adding. Added the unit tests. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/password_manager_presenter.h
diff --git a/chrome/browser/ui/passwords/password_manager_presenter.h b/chrome/browser/ui/passwords/password_manager_presenter.h
index 66c68462967c25cc4689f18f2bad21fa34f7e568..f7c700a716cbaff73959e82453541f6a3ff3dd42 100644
--- a/chrome/browser/ui/passwords/password_manager_presenter.h
+++ b/chrome/browser/ui/passwords/password_manager_presenter.h
@@ -46,6 +46,18 @@ class PasswordManagerPresenter
// Gets the password exception entry at |index|.
const autofill::PasswordForm* GetPasswordException(size_t index);
+ // Checks if |origin| is valid for adding a new password entry.
+ static bool CheckOriginValidityForAdding(const GURL& origin);
+
+ // Adds a new password entry with |origin|, |username_value|, and
+ // |password_value|.
+ void AddPassword(const GURL& origin,
vabr (Chromium) 2014/08/25 07:35:07 Please document restrictions on |origin| and |pass
jaekyeom 2014/08/26 05:34:48 Done.
+ const base::string16& username_value,
+ const base::string16& password_value);
+
+ // Updates the entry at |index| with |password_value|.
+ void UpdatePassword(size_t index, const base::string16& password_value);
vabr (Chromium) 2014/08/25 07:35:07 Please document restrictions on |password_value| (
jaekyeom 2014/08/26 05:34:48 Done.
+
// Removes the saved password entry at |index|.
// |index| the entry index to be removed.
void RemoveSavedPassword(size_t index);

Powered by Google App Engine
This is Rietveld 408576698