Allow editing passwords in settings/passwords

chrome/browser/ui/passwords/password_manager_presenter.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_
 
 #include <string>
 #include <vector>
 

[Dan Beam, 2014/09/11 05:17:58]

#include "base/basictypes.h"  // For size_t.

[jaekyeom, 2014/09/12 10:35:58]

Done.

 #include "base/memory/scoped_vector.h"
 #include "base/prefs/pref_member.h"
 #include "components/password_manager/core/browser/password_store.h"
 #include "components/password_manager/core/browser/password_store_consumer.h"
 
 namespace autofill {
 struct PasswordForm;
 }

[Dan Beam, 2014/09/11 05:17:58]

forward declare or include headers for:
- base::string16
- GURL

[jaekyeom, 2014/09/12 10:35:58]

Done.

 
 class PasswordUIView;
 
 class Profile;
 
 // Contains the common logic used by a PasswordUIView to
 // interact with PasswordStore. It provides completion callbacks for
 // PasswordStore operations and updates the view on PasswordStore changes.
 class PasswordManagerPresenter
     : public password_manager::PasswordStore::Observer {
  public:
   // |password_view| the UI view that owns this presenter, must not be NULL.
   explicit PasswordManagerPresenter(PasswordUIView* password_view);
   virtual ~PasswordManagerPresenter();
 

[Dan Beam, 2014/09/11 05:17:58]

^ static would probably go here

[jaekyeom, 2014/09/12 10:35:58]

Done.

   // PasswordStore::Observer implementation.
   virtual void OnLoginsChanged(
       const password_manager::PasswordStoreChangeList& changes) OVERRIDE;
 
   // Repopulates the password and exception entries.
   void UpdatePasswordLists();
 
   void Initialize();
 
   // Gets the password entry at |index|.
   const autofill::PasswordForm* GetPassword(size_t index);
 
   // Gets the password exception entry at |index|.
   const autofill::PasswordForm* GetPasswordException(size_t index);
 
+  // Checks if |origin| is valid for adding a new password entry.
+  static bool CheckOriginValidityForAdding(const GURL& origin);

[Dan Beam, 2014/09/11 05:17:58]

nit: move static method right under ctor

[jaekyeom, 2014/09/12 10:35:58]

Done.

+
+  // Adds a new password entry with |origin|, |username_value|, and
+  // |password_value|.  |origin| should have been validated by

[Dan Beam, 2014/09/11 05:17:58]

nit: 1 \s between sentences

[jaekyeom, 2014/09/12 10:35:58]

Done.

+  // CheckOriginValidityForAdding, and |password_value| should be non-empty.
+  void AddPassword(const GURL& origin,
+                   const base::string16& username_value,
+                   const base::string16& password_value);
+
+  // Updates the entry at |index| with |password_value|.  |password_value|
+  // should be non-empty.
+  void UpdatePassword(size_t index, const base::string16& password_value);
+
   // Removes the saved password entry at |index|.
   // |index| the entry index to be removed.
   void RemoveSavedPassword(size_t index);
 
   // Removes the saved password exception entry at |index|.
   // |index| the entry index to be removed.
   void RemovePasswordException(size_t index);
 
   // Requests the plain text password for entry at |index| to be revealed.
   // |index| The index of the entry.
@@ skipping 70 matching lines @@
   // Used to determine whether or not to reveal plaintext passwords.
   base::TimeTicks last_authentication_time_;
 
   // UI view that owns this presenter.
   PasswordUIView* password_view_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerPresenter);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_PASSWORD_MANAGER_PRESENTER_H_