Allow editing passwords in settings/passwords

chrome/browser/ui/webui/options/password_manager_handler.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/password_manager_handler.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 35 matching lines @@
     base::DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
 
   static const OptionsStringResource resources[] = {
     { "savedPasswordsTitle",
       IDS_PASSWORDS_SHOW_PASSWORDS_TAB_TITLE },
     { "passwordExceptionsTitle",
       IDS_PASSWORDS_EXCEPTIONS_TAB_TITLE },
     { "passwordSearchPlaceholder",
       IDS_PASSWORDS_PAGE_SEARCH_PASSWORDS },
+    { "newPasswordUrlFieldPlaceholder",
+      IDS_PASSWORDS_PAGE_URL_INSTRUCTION },
+    { "newPasswordUsernameFieldPlaceholder",
+      IDS_PASSWORDS_PAGE_USERNAME_INSTRUCTION },
+    { "newPasswordPasswordFieldPlaceholder",
+      IDS_PASSWORDS_PAGE_PASSWORD_INSTRUCTION },
+    { "editPasswordInvalidUrlTooltip",
+      IDS_PASSWORDS_PAGE_INVALID_URL_TOOLTIP },
+    { "editPasswordInvalidPasswordTooltip",
+      IDS_PASSWORDS_PAGE_INVALID_PASSWORD_TOOLTIP },
     { "passwordShowButton",
       IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON },
     { "passwordHideButton",
       IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON },
+    { "passwordOverwriteButton",
+      IDS_PASSWORDS_PAGE_VIEW_OVERWRITE_BUTTON },
     { "passwordsNoPasswordsDescription",
       IDS_PASSWORDS_PAGE_VIEW_NO_PASSWORDS_DESCRIPTION },
     { "passwordsNoExceptionsDescription",
       IDS_PASSWORDS_PAGE_VIEW_NO_EXCEPTIONS_DESCRIPTION },
   };
 
   RegisterStrings(localized_strings, resources, arraysize(resources));
   RegisterTitle(localized_strings, "passwordsPage",
                 IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE);
 
@@ skipping 12 matching lines @@
 
   localized_strings->SetBoolean("disableShowPasswords", disable_show_passwords);
 }
 
 void PasswordManagerHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
       "updatePasswordLists",
       base::Bind(&PasswordManagerHandler::HandleUpdatePasswordLists,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
+      "checkOriginValidityForAdding",
+      base::Bind(&PasswordManagerHandler::HandleCheckOriginValidityForAdding,
+                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "addPassword",
+      base::Bind(&PasswordManagerHandler::HandleAddPassword,
+                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "updatePassword",
+      base::Bind(&PasswordManagerHandler::HandleUpdatePassword,
+                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
       "removeSavedPassword",
       base::Bind(&PasswordManagerHandler::HandleRemoveSavedPassword,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "removePasswordException",
       base::Bind(&PasswordManagerHandler::HandleRemovePasswordException,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "requestShowPassword",
       base::Bind(&PasswordManagerHandler::HandleRequestShowPassword,
                  base::Unretained(this)));
 }
 
 void PasswordManagerHandler::InitializeHandler() {
   password_manager_presenter_.Initialize();
 }
 
+void PasswordManagerHandler::HandleCheckOriginValidityForAdding(
+    const base::ListValue* args) {
+  std::string origin;
+  const bool success = args->GetString(0, &origin);
+  DCHECK(success);  // Don't CHECK here since the renderer might be compromised.
+  web_ui()->CallJavascriptFunction(
+      "PasswordManager.originValidityCheckComplete",
+      base::StringValue(origin),
+      base::FundamentalValue(
+          PasswordManagerPresenter::CheckOriginValidityForAdding(
+              GURL(origin))));
+}
+
+void PasswordManagerHandler::HandleAddPassword(const base::ListValue* args) {
+  std::string origin;
+  base::string16 username_value;
+  base::string16 password_value;
+  if (!args->GetString(0, &origin) || !args->GetString(1, &username_value) ||
+      !args->GetString(2, &password_value)) {
+    NOTREACHED();
+    return;
+  }
+  password_manager_presenter_.AddPassword(GURL(origin), username_value,
+                                          password_value);
+}
+
+void PasswordManagerHandler::HandleUpdatePassword(const base::ListValue* args) {
+  int index;
+  if (!ExtractIntegerValue(args, &index) || index < 0) {

[engedy, 2014/09/15 14:38:59]

To reduce total number of lines, could you please also combine this check with
the next one?

[jaekyeom, 2014/09/16 07:58:10]

Done.

+    NOTREACHED();
+    return;
+  }
+
+  base::string16 password_value;
+  if (args->GetString(1, &password_value)) {
+    password_manager_presenter_.UpdatePassword(static_cast<size_t>(index),
+                                               password_value);
+  } else {
+    NOTREACHED();
+  }
+}
+
 void PasswordManagerHandler::HandleRemoveSavedPassword(
     const base::ListValue* args) {
   std::string string_value = base::UTF16ToUTF8(ExtractStringValue(args));
   int index;
   if (base::StringToInt(string_value, &index) && index >= 0) {
     password_manager_presenter_.RemoveSavedPassword(static_cast<size_t>(index));
   }
 }
 
 void PasswordManagerHandler::HandleRemovePasswordException(
@@ skipping 61 matching lines @@
   for (size_t i = 0; i < password_exception_list.size(); ++i) {
     entries.Append(new base::StringValue(
         net::FormatUrl(password_exception_list[i]->origin, languages_)));
   }
 
   web_ui()->CallJavascriptFunction("PasswordManager.setPasswordExceptionsList",
                                    entries);
 }
 
 }  // namespace options