Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Side by Side Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 489103004: Allow editing passwords in settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/password_manager_handler.h" 5 #include "chrome/browser/ui/webui/options/password_manager_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 82
83 localized_strings->SetBoolean("disableShowPasswords", disable_show_passwords); 83 localized_strings->SetBoolean("disableShowPasswords", disable_show_passwords);
84 } 84 }
85 85
86 void PasswordManagerHandler::RegisterMessages() { 86 void PasswordManagerHandler::RegisterMessages() {
87 web_ui()->RegisterMessageCallback( 87 web_ui()->RegisterMessageCallback(
88 "updatePasswordLists", 88 "updatePasswordLists",
89 base::Bind(&PasswordManagerHandler::HandleUpdatePasswordLists, 89 base::Bind(&PasswordManagerHandler::HandleUpdatePasswordLists,
90 base::Unretained(this))); 90 base::Unretained(this)));
91 web_ui()->RegisterMessageCallback( 91 web_ui()->RegisterMessageCallback(
92 "updatePassword",
93 base::Bind(&PasswordManagerHandler::HandleUpdatePassword,
94 base::Unretained(this)));
95 web_ui()->RegisterMessageCallback(
92 "removeSavedPassword", 96 "removeSavedPassword",
93 base::Bind(&PasswordManagerHandler::HandleRemoveSavedPassword, 97 base::Bind(&PasswordManagerHandler::HandleRemoveSavedPassword,
94 base::Unretained(this))); 98 base::Unretained(this)));
95 web_ui()->RegisterMessageCallback( 99 web_ui()->RegisterMessageCallback(
96 "removePasswordException", 100 "removePasswordException",
97 base::Bind(&PasswordManagerHandler::HandleRemovePasswordException, 101 base::Bind(&PasswordManagerHandler::HandleRemovePasswordException,
98 base::Unretained(this))); 102 base::Unretained(this)));
99 web_ui()->RegisterMessageCallback( 103 web_ui()->RegisterMessageCallback(
100 "requestShowPassword", 104 "requestShowPassword",
101 base::Bind(&PasswordManagerHandler::HandleRequestShowPassword, 105 base::Bind(&PasswordManagerHandler::HandleRequestShowPassword,
102 base::Unretained(this))); 106 base::Unretained(this)));
103 } 107 }
104 108
105 void PasswordManagerHandler::InitializeHandler() { 109 void PasswordManagerHandler::InitializeHandler() {
106 password_manager_presenter_.Initialize(); 110 password_manager_presenter_.Initialize();
107 } 111 }
108 112
113 void PasswordManagerHandler::HandleUpdatePassword(const base::ListValue* args) {
114 int index;
115 if (!ExtractIntegerValue(args, &index) || index < 0)
116 return;
117
118 base::string16 password_value;
119 if (args->GetString(1, &password_value)) {
120 password_manager_presenter_.UpdatePassword(static_cast<size_t>(index),
121 password_value);
122 }
123 }
124
109 void PasswordManagerHandler::HandleRemoveSavedPassword( 125 void PasswordManagerHandler::HandleRemoveSavedPassword(
110 const base::ListValue* args) { 126 const base::ListValue* args) {
111 std::string string_value = base::UTF16ToUTF8(ExtractStringValue(args)); 127 std::string string_value = base::UTF16ToUTF8(ExtractStringValue(args));
112 int index; 128 int index;
113 if (base::StringToInt(string_value, &index) && index >= 0) { 129 if (base::StringToInt(string_value, &index) && index >= 0) {
114 password_manager_presenter_.RemoveSavedPassword(static_cast<size_t>(index)); 130 password_manager_presenter_.RemoveSavedPassword(static_cast<size_t>(index));
115 } 131 }
116 } 132 }
117 133
118 void PasswordManagerHandler::HandleRemovePasswordException( 134 void PasswordManagerHandler::HandleRemovePasswordException(
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 for (size_t i = 0; i < password_exception_list.size(); ++i) { 196 for (size_t i = 0; i < password_exception_list.size(); ++i) {
181 entries.Append(new base::StringValue( 197 entries.Append(new base::StringValue(
182 net::FormatUrl(password_exception_list[i]->origin, languages_))); 198 net::FormatUrl(password_exception_list[i]->origin, languages_)));
183 } 199 }
184 200
185 web_ui()->CallJavascriptFunction("PasswordManager.setPasswordExceptionsList", 201 web_ui()->CallJavascriptFunction("PasswordManager.setPasswordExceptionsList",
186 entries); 202 entries);
187 } 203 }
188 204
189 } // namespace options 205 } // namespace options
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698