Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 489103003: remove code for (dead) SK_SUPPORT_LEGACY_GETCLIPTYPE (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove code for (dead) SK_SUPPORT_LEGACY_GETCLIPTYPE BUG=skia: Committed: https://skia.googlesource.com/skia/+/8bf3df68c58967d6297ccfe3eef36eea36c8b5ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
reed1
6 years, 4 months ago (2014-08-20 23:19:42 UTC) #1
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-20 23:19:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/489103003/1
6 years, 4 months ago (2014-08-20 23:20:39 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-20 23:20:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 05:20:39 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 4 months ago (2014-08-21 05:20:40 UTC) #6
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-21 12:20:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/489103003/1
6 years, 4 months ago (2014-08-21 12:21:00 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-21 12:21:01 UTC) #9
djsollen
lgtm
6 years, 4 months ago (2014-08-21 12:49:11 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 12:51:28 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (1) as 8bf3df68c58967d6297ccfe3eef36eea36c8b5ab

Powered by Google App Engine
This is Rietveld 408576698