Enabling archiving of test results by default in run-webkit-tests.

Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py

 # Copyright (C) 2014 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
 # in the documentation and/or other materials provided with the
 # distribution.
 #     * Neither the name of Google Inc. nor the names of its
 # contributors may be used to endorse or promote products derived from
 # this software without specific prior written permission.
 #
 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import json
+import logging
 
 
 class ProcessJsonData(object):
 
     def __init__(self, current_result_json_dict, old_failing_results_list, old_full_results_list):
         self._current_result_json_dict = current_result_json_dict
         self._old_failing_results_list = old_failing_results_list
         self._old_full_results_list = old_full_results_list
         self._final_result = []
 
@@ skipping 69 matching lines @@
             if self._filesystem.exists(dashboard_html_file_path):
                 self._filesystem.copyfile(dashboard_html_file_path, dashboard_file)
 
     def _initialize(self):
         file_list = self._filesystem.listdir(self._results_directory_path)
         results_directories = []
         for dir in file_list:
             if self._filesystem.isdir(self._filesystem.join(self._results_directory_path, dir)):
                 results_directories.append(self._filesystem.join(self._results_directory_path, dir))
         results_directories.sort(reverse=True, key=lambda x: self._filesystem.mtime(x))
-        with open(self._filesystem.join(results_directories[0], 'failing_results.json'), "r") as file:
-            input_json_string = file.readline()
+        current_failing_results_json_file = self._filesystem.join(results_directories[0], 'failing_results.json')
+        try:
+            file = open(current_failing_results_json_file, "r")
+        except IOError:
+            logging.debug("Could not generate archived results dashboard failing_results.json does not exist")
+            return

[Dirk Pranke, 2014/09/05 21:07:31]

I don't think we should catch this error. It shouldn't normally happen, and a
debug message is just going to be ignored. We should let the exception
propagate.

[patro, 2014/09/06 06:50:55]

Done.

+        input_json_string = file.readline()
         input_json_string = input_json_string[12:-2]   # Remove preceeding string ADD_RESULTS( and ); at the end
         self._current_result_json_dict['tests'] = json.loads(input_json_string)['tests']
         results_directories = results_directories[1:]
 
         # To add hyperlink to individual results.html
         self._add_individual_result_links(results_directories)
 
         # Load the remaining stale layout test results Json's to create the dashboard
         for json_file in results_directories:
-            with open(self._filesystem.join(json_file, 'failing_results.json'), "r") as file:
+            failing_json_file_path = self._filesystem.join(json_file, 'failing_results.json')
+            full_json_file_path = self._filesystem.join(json_file, 'full_results.json')
+            with open(failing_json_file_path, "r") as file:
                 json_string = file.readline()
             json_string = json_string[12:-2]   # Remove preceeding string ADD_RESULTS( and ); at the end
             self._old_failing_results_list.append(json.loads(json_string))
 
-            with open(self._filesystem.join(json_file, 'full_results.json'), "r") as full_file:
+            with open(full_json_file_path, "r") as full_file:
                 json_string_full_result = full_file.readline()
             self._old_full_results_list.append(json.loads(json_string_full_result))
         self._copy_dashboard_html()
 
     def generate(self):
         self._initialize()
-        process_json_data = ProcessJsonData(self._current_result_json_dict, self._old_failing_results_list, self._old_full_results_list)
-        self._final_result = process_json_data.generate_archived_result()
-        final_json = json.dumps(self._final_result)
-        final_json = 'ADD_RESULTS(' + final_json + ');'
-        with open(self._filesystem.join(self._results_directory, 'archived_results.json'), "w") as file:
-            file.write(final_json)
+
+        # There must be atleast one archived result to be processed
+        if self._current_result_json_dict:
+            process_json_data = ProcessJsonData(self._current_result_json_dict, self._old_failing_results_list, self._old_full_results_list)
+            self._final_result = process_json_data.generate_archived_result()
+            final_json = json.dumps(self._final_result)
+            final_json = 'ADD_RESULTS(' + final_json + ');'
+            with open(self._filesystem.join(self._results_directory, 'archived_results.json'), "w") as file:
+                file.write(final_json)