Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 489033003: extensions: Speculative fix for crash on IO thread. (Closed)

Created:
6 years, 4 months ago by Daniel Erat
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

extensions: Speculative fix for crash on IO thread. Make ExtensionFunctionDispatcher::DispatchOnIOThread() return early if the extension that was passed to it doesn't exist anymore. BUG=406062 Committed: https://crrev.com/5122f4eb8fa975f8e7037e5c27075e0acb3c0890 Cr-Commit-Position: refs/heads/master@{#291618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M extensions/browser/extension_function_dispatcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Erat
6 years, 4 months ago (2014-08-23 19:03:43 UTC) #1
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-23 19:27:06 UTC) #2
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 4 months ago (2014-08-23 20:10:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/489033003/1
6 years, 4 months ago (2014-08-23 20:11:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-23 21:29:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as b3fca8f3f90ffec11c6cf9d923f142ae6fa8f165
6 years, 4 months ago (2014-08-24 04:10:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5122f4eb8fa975f8e7037e5c27075e0acb3c0890
Cr-Commit-Position: refs/heads/master@{#291618}

Powered by Google App Engine
This is Rietveld 408576698