Run dart2js transformer sequentially.

Run dart2js transformer sequentially.

BUG=
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29782

[nweiz, 2013-11-01 23:56:29]

It would be nice to add a TODO to test this somewhere.

https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (right):

https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:45: Completer
_running;
Nit, but I'd have the instance variable be a Future and keep the Completer local
to [apply].

https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:65: });
If more than two dart2js instances are running at once, this is going to produce
a lot of "Resuming dart2js.\ndart2js is already running" messages, since only
one instance will be able to start at a time. Maybe add a TODO to convert this
Future into a queue instead.

[nweiz, 2013-11-01 23:56:37]

Oh and lgtm.

On 2013/11/01 23:56:29, nweiz wrote:
> It would be nice to add a TODO to test this somewhere.
> 
>
https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
> File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (right):
> 
>
https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
> sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:45: Completer
> _running;
> Nit, but I'd have the instance variable be a Future and keep the Completer
local
> to [apply].
> 
>
https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
> sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:65: });
> If more than two dart2js instances are running at once, this is going to
produce
> a lot of "Resuming dart2js.\ndart2js is already running" messages, since only
> one instance will be able to start at a time. Maybe add a TODO to convert this
> Future into a queue instead.

[Bob Nystrom, 2013-11-02 00:07:40]

Thanks!

https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart (right):

https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:45: Completer
_running;
On 2013/11/01 23:56:30, nweiz wrote:
> Nit, but I'd have the instance variable be a Future and keep the Completer
local
> to [apply].

Done.

https://codereview.chromium.org/48903020/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart:65: });
On 2013/11/01 23:56:30, nweiz wrote:
> If more than two dart2js instances are running at once, this is going to
produce
> a lot of "Resuming dart2js.\ndart2js is already running" messages, since only
> one instance will be able to start at a time. Maybe add a TODO to convert this
> Future into a queue instead.

Took out the logging. Added a TODO.

[Bob Nystrom, 2013-11-02 00:11:49]

Committed patchset #3 manually as r29782 (presubmit successful).