Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 48903012: Switch "Downloads" directory path to the per-profile ones for multi-profile support. (Closed)

Created:
7 years, 1 month ago by kinaba
Modified:
6 years, 11 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Switch "Downloads" directory path to the per-profile ones for multi-profile support. All migration code has already landed. This is the final CL that carries out the switch. By this CL, Files.app in multi-profile session starts showing each profile's Downloads folder, not the primary profile's one. This is a transient state for the future fully-multiprofile-aware Files.app (ETA: M34) that shows all profile's folder in a single window. The following is the summary/background why the path switch is needed: We had used /home/chronos/user/Download as the path to the "Downloads" folder for all users. This does not hold for multi-profile session. The "real" path for multiple users are /home/chronos/u-unique-hash-userA/Downloads /home/chronos/u-unique-hash-userB/Downloads ... and /home/chronos/user is just an alias to the user who first signed into the session. To make all user's folder available simultaneously in one multi-profile session, we need to stop using the alias, and differentiate all folders by the real path. BUG=309556 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243794

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/browser/chromeos/file_manager/path_util.cc View 2 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
6 years, 11 months ago (2014-01-09 03:54:16 UTC) #1
hirono
lgtm!
6 years, 11 months ago (2014-01-09 04:08:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/48903012/130001
6 years, 11 months ago (2014-01-09 05:38:51 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 07:31:07 UTC) #4
Message was sent while issue was closed.
Change committed as 243794

Powered by Google App Engine
This is Rietveld 408576698