Issue 489023003: rebaseline_server: force checksumValue to an integer to prevent spurious comparison failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 489023003: rebaseline_server: force checksumValue to an integer to prevent spurious comparison failures (Closed)

Created:
6 years, 4 months ago by epoger

Modified:
6 years, 4 months ago

Reviewers:
stephana

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

rebaseline_server: force checksumValue to an integer to prevent spurious comparison failures Without this change, SKP tests *appeared* to fail because the actuals reported their checksumValues as integers, while the expectations recorded their checksumValues as strings. NOTREECHECKS=true NOTRY=true TBR=stephana (SkipBuildbotRuns) Committed: https://skia.googlesource.com/skia/+/260d2375667f875b4d5ff8c7d6f268a1fc0b8b53

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gm/rebaseline_server/compare_rendered_pictures.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/489023003/1

6 years, 4 months ago (2014-08-20 19:21:41 UTC) #3

commit-bot: I haz the power

6 years, 4 months ago (2014-08-20 19:21:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 260d2375667f875b4d5ff8c7d6f268a1fc0b8b53

Expand Messages | Collapse Messages