Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 488993004: Move kGroupCount out of DependencyGroup enum. (Closed)

Created:
6 years, 4 months ago by Vyacheslav Egorov (Google)
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move kGroupCount out of DependencyGroup enum. BUG= R=svenpanne@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23366

Patch Set 1 #

Total comments: 2

Patch Set 2 : make it static const int #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/objects.h View 1 1 chunk +3 lines, -2 lines 1 comment Download
M src/objects.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
https://codereview.chromium.org/488993004/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/488993004/diff/1/src/objects.h#newcode5962 src/objects.h:5962: enum { kGroupCount = kAllocationSiteTransitionChangedGroup + 1 }; does ...
6 years, 4 months ago (2014-08-25 12:12:43 UTC) #1
Vyacheslav Egorov (Google)
https://codereview.chromium.org/488993004/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/488993004/diff/1/src/objects.h#newcode5962 src/objects.h:5962: enum { kGroupCount = kAllocationSiteTransitionChangedGroup + 1 }; On ...
6 years, 4 months ago (2014-08-25 12:16:51 UTC) #2
Vyacheslav Egorov (Google)
+svenpanne, +verwaest as reviewers
6 years, 4 months ago (2014-08-25 12:17:24 UTC) #3
Yang
On 2014/08/25 12:17:24, Vyacheslav Egorov (Google wrote: > +svenpanne, +verwaest as reviewers lgtm
6 years, 4 months ago (2014-08-25 12:23:05 UTC) #4
Sven Panne
LGTM from my side, too. https://codereview.chromium.org/488993004/diff/20001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/488993004/diff/20001/src/objects.h#newcode5962 src/objects.h:5962: static const int kGroupCount ...
6 years, 4 months ago (2014-08-25 13:18:30 UTC) #5
Vyacheslav Egorov (Google)
6 years, 4 months ago (2014-08-25 15:41:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as 23366 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698