Credential Manager: Migrate to WebView client-based approach.

public/platform/WebCredentialManagerClient.h

Index: public/platform/WebCredentialManagerClient.h
diff --git a/public/platform/WebCredentialManager.h b/public/platform/WebCredentialManagerClient.h
similarity index 61%
rename from public/platform/WebCredentialManager.h
rename to public/platform/WebCredentialManagerClient.h
index 9bd239acf34f2ab8c538681b1c1c342d0102430c..482ec96f70113d7902d77b1dc36d6f7f10d3c033 100644
--- a/public/platform/WebCredentialManager.h
+++ b/public/platform/WebCredentialManagerClient.h
@@ -2,31 +2,32 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef WebCredentialManager_h
-#define WebCredentialManager_h
+#ifndef WebCredentialManagerClient_h
+#define WebCredentialManagerClient_h
 
 #include "public/platform/WebCallbacks.h"
 #include "public/platform/WebCredentialManagerError.h"
-#include "public/platform/WebString.h"
 #include "public/platform/WebVector.h"
 
 namespace blink {
 
-// WebCredentialManager provides an interface for asking Blink's embedder to
-// respond to `navigator.credentials.*` calls.
-class WebCredentialManager {
+class WebCredential;
+class WebURL;
+
+// WebCredentialManagerClient is an interface which allows an embedder to
+// implement 'navigator.credential.*' calls which are defined in the
+// 'credentialmanager' module.
+class WebCredentialManagerClient {
 public:
     typedef WebCallbacks<WebCredential, WebCredentialManagerError> RequestCallbacks;
     typedef WebCallbacks<void, WebCredentialManagerError> NotificationCallbacks;
 
-    WebCredentialManager() { }
-    virtual ~WebCredentialManager() { }
-
-    // Ownership of the callback is transferred to the callee for each of the following methods.
-    virtual void dispatchFailedSignIn(const WebCredential&, NotificationCallbacks*) { }
-    virtual void dispatchSignedIn(const WebCredential&, NotificationCallbacks*) { }
-    virtual void dispatchSignedOut(NotificationCallbacks*) { }
-    virtual void dispatchRequest(bool zeroClickOnly, const WebVector<WebURL>& federations, RequestCallbacks*) { }
+    // Ownership of the callback is transferred to the callee for each of
+    // the following methods.
+    virtual void dispatchFailedSignIn(const WebCredential&, NotificationCallbacks*) = 0;

[pfeldman, 2014/08/20 12:23:43]

Do you plan on further growing this interface? If yes, define stub { }
implementations and it will make two-sided patches easier to land.

[Mike West, 2014/08/20 13:05:43]

Sounds reasonable. It's not yet clear what the API will end up looking like;
once it's locked down, we can make this a pure interface again.

+    virtual void dispatchSignedIn(const WebCredential&, NotificationCallbacks*) = 0;
+    virtual void dispatchSignedOut(NotificationCallbacks*) = 0;
+    virtual void dispatchRequest(bool zeroClickOnly, const WebVector<WebURL>& federations, RequestCallbacks*) = 0;
 };
 
 } // namespace blink