Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 48893003: QUIC - added googlevideo.com to the list of cannonical hostnames to (Closed)

Created:
7 years, 1 month ago by ramant (doing other things)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

QUIC - added googlevideo.com to the list of cannonical hostnames to share the server config for 0-RTT for youtube videos. R=jar@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234670

Patch Set 1 : share server_config #

Patch Set 2 : added unit test #

Total comments: 2

Patch Set 3 : include vector #

Patch Set 4 : merging with tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -59 lines) Patch
M net/quic/quic_stream_factory.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 3 chunks +14 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 2 chunks +81 lines, -55 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
ramant (doing other things)
7 years, 1 month ago (2013-11-01 02:42:57 UTC) #1
jar (doing other things)
LGTM % tiny nit https://codereview.chromium.org/48893003/diff/650001/net/quic/quic_stream_factory.h File net/quic/quic_stream_factory.h (right): https://codereview.chromium.org/48893003/diff/650001/net/quic/quic_stream_factory.h#newcode10 net/quic/quic_stream_factory.h:10: nit: go ahead and include ...
7 years, 1 month ago (2013-11-01 23:12:01 UTC) #2
ramant (doing other things)
thanks very much Jim. Added the include. https://codereview.chromium.org/48893003/diff/650001/net/quic/quic_stream_factory.h File net/quic/quic_stream_factory.h (right): https://codereview.chromium.org/48893003/diff/650001/net/quic/quic_stream_factory.h#newcode10 net/quic/quic_stream_factory.h:10: On 2013/11/01 ...
7 years, 1 month ago (2013-11-01 23:28:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/48893003/690001
7 years, 1 month ago (2013-11-01 23:36:13 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217900
7 years, 1 month ago (2013-11-02 02:59:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/48893003/690001
7 years, 1 month ago (2013-11-11 03:02:18 UTC) #6
ramant (doing other things)
7 years, 1 month ago (2013-11-11 03:05:26 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-11 03:07:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/48893003/690001
7 years, 1 month ago (2013-11-11 03:51:44 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-11 16:12:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/48893003/1100001
7 years, 1 month ago (2013-11-11 22:04:32 UTC) #11
ramant (doing other things)
7 years, 1 month ago (2013-11-12 22:14:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/48893003/1100001
7 years, 1 month ago (2013-11-12 23:30:03 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 00:17:18 UTC) #14
Message was sent while issue was closed.
Change committed as 234670

Powered by Google App Engine
This is Rietveld 408576698