Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 488923004: Oilpan: fix g++ (4.8) building after r180659. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Project:
blink
Visibility:
Public.

Description

Oilpan: fix g++ (4.8) building after r180659. Pin down the resolution of + to be over int by converting the enum value. R=haraken,zerny BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-22 13:44:57 UTC) #1
haraken
LGTM
6 years, 4 months ago (2014-08-22 13:45:21 UTC) #2
zerny-chromium
lgtm
6 years, 4 months ago (2014-08-22 13:56:36 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-22 13:58:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/488923004/1
6 years, 4 months ago (2014-08-22 13:59:11 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 13:59:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180774

Powered by Google App Engine
This is Rietveld 408576698