Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: chrome/browser/printing/print_job_worker.h

Issue 488913002: Use scoped_ptr to pass settings in PrintJobWorker and PrinterQuery. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tue Aug 19 19:59:20 PDT 2014 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/printing/print_job_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job_worker.h
diff --git a/chrome/browser/printing/print_job_worker.h b/chrome/browser/printing/print_job_worker.h
index c3c9cf51b04699549aa258640186ef5835307b70..e3e9a6747014fb4a97fe0bd7c6ae40395f4a3c06 100644
--- a/chrome/browser/printing/print_job_worker.h
+++ b/chrome/browser/printing/print_job_worker.h
@@ -52,9 +52,9 @@ class PrintJobWorker {
bool has_selection,
MarginType margin_type);
- // Set the new print settings. This function takes ownership of
- // |new_settings|.
- void SetSettings(const base::DictionaryValue* const new_settings);
+ // Set the new print settings.
+ void SetSettings(
+ scoped_ptr<base::DictionaryValue> new_settings);
// Starts the printing loop. Every pages are printed as soon as the data is
// available. Makes sure the new_document is the right one.
@@ -122,9 +122,8 @@ class PrintJobWorker {
// back into the IO thread for GetSettingsDone().
void GetSettingsWithUIDone(PrintingContext::Result result);
- // Called on the UI thread to update the print settings. This function takes
- // the ownership of |new_settings|.
- void UpdatePrintSettings(const base::DictionaryValue* const new_settings);
+ // Called on the UI thread to update the print settings.
+ void UpdatePrintSettings(scoped_ptr<base::DictionaryValue> new_settings);
// Reports settings back to owner_.
void GetSettingsDone(PrintingContext::Result result);
« no previous file with comments | « no previous file | chrome/browser/printing/print_job_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698