Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 488913002: Use scoped_ptr to pass settings in PrintJobWorker and PrinterQuery. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 4 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr to pass settings in PrintJobWorker and PrinterQuery. BUG=374321 TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290799

Patch Set 1 #

Patch Set 2 : Tue Aug 19 19:59:20 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M chrome/browser/printing/print_job_worker.h View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/printer_query.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printer_query.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 02:59:53 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-20 02:59:57 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 03:00:00 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 03:00:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/488913002/20001
6 years, 4 months ago (2014-08-20 03:01:06 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-20 09:02:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (20001) as 290799
6 years, 4 months ago (2014-08-20 09:53:52 UTC) #7
Noam Samuel
6 years, 4 months ago (2014-08-20 18:07:33 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698