Issue 488863004: Revert of Add logging for ScriptedAnimationController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 488863004: Revert of Add logging for ScriptedAnimationController. (Closed)

Created:
6 years, 4 months ago by dglazkov

Modified:
6 years, 4 months ago

Reviewers:
Ken Russell (switch to Gerrit), Zhenyao Mo, eseidel

CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, darktears, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of Add logging for ScriptedAnimationController. (patchset #1 of https://codereview.chromium.org/484323002/) Reason for revert: Broke https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20(dbg)/builds/33277/steps/compile/logs/stdio Original issue's description: > Add logging for ScriptedAnimationController. > > This is for debugging RAF based WebGL conformance tests random timeouts. > > BUG=393331 > TEST=bots > NOTRY=true > R=kbr@chromium.org,eseidel@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180672 TBR=eseidel@chromium.org,kbr@chromium.org,zmo@chromium.org NOTREECHECKS=true NOTRY=true BUG=393331 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180682

Patch Set 1 #

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -16 lines)			Patch
M	Source/core/dom/ScriptedAnimationController.cpp	View	8 chunks	+0 lines, -11 lines	0 comments	Download
M	Source/platform/Logging.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/platform/Logging.cpp	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dglazkov

Created Revert of Add logging for ScriptedAnimationController.

6 years, 4 months ago (2014-08-20 20:11:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/488863004/1

6 years, 4 months ago (2014-08-20 20:12:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (1) as 180682

Expand Messages | Collapse Messages