Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 488833003: Add libxkbcommon-dev to install-build-deps (Closed)

Created:
6 years, 4 months ago by spang
Modified:
6 years, 4 months ago
Reviewers:
Shu Chen, kpschoedel
CC:
chromium-reviews, alexst (slow to review), ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add libxkbcommon-dev to install-build-deps We'll use this under ChromeOS ozone/freon builds for keyboard layout support. BUG=362698 TEST=ran install-build-deps.sh on trusty Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
spang
6 years, 4 months ago (2014-08-19 23:53:25 UTC) #1
Shu Chen
lgtm
6 years, 4 months ago (2014-08-20 00:11:41 UTC) #2
spang
The CQ bit was checked by spang@chromium.org
6 years, 4 months ago (2014-08-20 00:11:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/488833003/1
6 years, 4 months ago (2014-08-20 00:12:15 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 00:58:16 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 01:57:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290727

Powered by Google App Engine
This is Rietveld 408576698