Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 48883003: Add no-variants option to test runner. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, rmcilroy
Visibility:
Public.

Description

Add no-variants option to test runner. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/run-tests.py View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 1 month ago (2013-10-31 09:11:29 UTC) #1
Jakob Kummerow
LGTM. That "if not excl(...)" check is even more hardening against user error than I ...
7 years, 1 month ago (2013-10-31 09:27:56 UTC) #2
Michael Achenbach
7 years, 1 month ago (2013-10-31 10:14:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17440.

Powered by Google App Engine
This is Rietveld 408576698