Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 488763004: Fix smooth_gesture_util to adjust the gesture record properly (Closed)

Created:
6 years, 4 months ago by nednguyen(REVIEW IN OTHER ACC)
Modified:
6 years, 4 months ago
Reviewers:
nednguyen, nduca, ernstm, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix smooth_gesture_util to adjust the gesture record properly. Add unittest that fails crbug/399671 but pass with the fix. BUG=399671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291249

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -11 lines) Patch
M tools/perf/measurements/smooth_gesture_util.py View 1 chunk +7 lines, -6 lines 0 comments Download
M tools/perf/measurements/smooth_gesture_util_unittest.py View 1 3 chunks +88 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nednguyen
6 years, 4 months ago (2014-08-19 23:47:00 UTC) #1
nednguyen
On 2014/08/19 23:47:00, nednguyen wrote: Bug 399671 is P1, PTAL
6 years, 4 months ago (2014-08-19 23:48:10 UTC) #2
ernstm
https://codereview.chromium.org/488763004/diff/20001/tools/perf/measurements/smooth_gesture_util_unittest.py File tools/perf/measurements/smooth_gesture_util_unittest.py (right): https://codereview.chromium.org/488763004/diff/20001/tools/perf/measurements/smooth_gesture_util_unittest.py#newcode24 tools/perf/measurements/smooth_gesture_util_unittest.py:24: # [ X ] [ Y ] Is the ...
6 years, 4 months ago (2014-08-20 22:13:35 UTC) #3
nednguyen
https://codereview.chromium.org/488763004/diff/20001/tools/perf/measurements/smooth_gesture_util_unittest.py File tools/perf/measurements/smooth_gesture_util_unittest.py (right): https://codereview.chromium.org/488763004/diff/20001/tools/perf/measurements/smooth_gesture_util_unittest.py#newcode24 tools/perf/measurements/smooth_gesture_util_unittest.py:24: # [ X ] [ Y ] On 2014/08/20 ...
6 years, 4 months ago (2014-08-21 16:35:03 UTC) #4
ernstm
LGTM On 2014/08/21 16:35:03, nednguyen wrote: > https://codereview.chromium.org/488763004/diff/20001/tools/perf/measurements/smooth_gesture_util_unittest.py > File tools/perf/measurements/smooth_gesture_util_unittest.py (right): > > https://codereview.chromium.org/488763004/diff/20001/tools/perf/measurements/smooth_gesture_util_unittest.py#newcode24 ...
6 years, 4 months ago (2014-08-21 18:31:13 UTC) #5
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 4 months ago (2014-08-21 18:31:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@chromium.org/488763004/40001
6 years, 4 months ago (2014-08-21 18:35:47 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:48:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (40001) as 291249

Powered by Google App Engine
This is Rietveld 408576698