Issue 488763002: Introduce HTMLDataListOptionsCollection subclass for HTMLCollection

Issue 488763002: Introduce HTMLDataListOptionsCollection subclass for HTMLCollection (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
haraken, adamk

CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Introduce HTMLDataListOptionsCollection subclass for HTMLCollection Introduce HTMLDataListOptionsCollection subclass for HTMLCollection to improve code readability. This moves the element matching logic out of HTMLCollection and allows for tighter typing since an HTMLDataListOptionsCollection can only contain HTMLOptionElements. This gets rid of a lot of casting at call sites. R=adamk@chromium.org, haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180675

Patch Set 1 #

Total comments: 3

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -25 lines)			Patch
M	Source/bindings/scripts/v8_types.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLDataListElement.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLDataListElement.cpp	View	2 chunks	+3 lines, -2 lines	0 comments	Download
A	Source/core/html/HTMLDataListOptionsCollection.h	View	1 chunk	+44 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLFormControlElement.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLInputElement.cpp	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/core/html/forms/ColorInputType.cpp	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/html/forms/RangeInputType.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderTheme.cpp	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	Source/web/WebInputElement.cpp	View	1 chunk	+1 line, -0 lines	3 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/488763002/diff/1/Source/web/WebInputElement.cpp File Source/web/WebInputElement.cpp (right): https://codereview.chromium.org/488763002/diff/1/Source/web/WebInputElement.cpp#newcode38 Source/web/WebInputElement.cpp:38: #include "core/html/HTMLDataListOptionsCollection.h" What is this #include for?

6 years, 4 months ago (2014-08-20 00:40:08 UTC) #2

Inactive

https://codereview.chromium.org/488763002/diff/1/Source/web/WebInputElement.cpp File Source/web/WebInputElement.cpp (right): https://codereview.chromium.org/488763002/diff/1/Source/web/WebInputElement.cpp#newcode38 Source/web/WebInputElement.cpp:38: #include "core/html/HTMLDataListOptionsCollection.h" On 2014/08/20 00:40:08, haraken wrote: > > ...

6 years, 4 months ago (2014-08-20 15:15:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/488763002/1

6 years, 4 months ago (2014-08-20 18:44:33 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (1) as 180675

Expand Messages | Collapse Messages