Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Side by Side Diff: chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc

Issue 488743003: Disable a flaky test under MemorySanitizer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "chrome/browser/extensions/extension_apitest.h" 8 #include "chrome/browser/extensions/extension_apitest.h"
9 #include "chrome/browser/extensions/extension_test_message_listener.h" 9 #include "chrome/browser/extensions/extension_test_message_listener.h"
10 #include "chrome/browser/extensions/tab_helper.h" 10 #include "chrome/browser/extensions/tab_helper.h"
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 false); 227 false);
228 fullscreen_entered.Reply(""); 228 fullscreen_entered.Reply("");
229 229
230 ResultCatcher catcher; 230 ResultCatcher catcher;
231 catcher.RestrictToProfile(browser()->profile()); 231 catcher.RestrictToProfile(browser()->profile());
232 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 232 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
233 } 233 }
234 234
235 // Times out on Win dbg bots: http://crbug.com/177163 235 // Times out on Win dbg bots: http://crbug.com/177163
236 // #if defined(OS_WIN) && !defined(NDEBUG) 236 // #if defined(OS_WIN) && !defined(NDEBUG)
237 // Times out on all Win bots: http://crbug.com/294431 237 // Times out on all Win bots, flaky on MSan bots: http://crbug.com/294431
238 #if defined(OS_WIN) 238 #if defined(OS_WIN) || defined(MEMORY_SANITIZER)
239 #define MAYBE_GrantForChromePages DISABLED_GrantForChromePages 239 #define MAYBE_GrantForChromePages DISABLED_GrantForChromePages
240 #else 240 #else
241 #define MAYBE_GrantForChromePages GrantForChromePages 241 #define MAYBE_GrantForChromePages GrantForChromePages
242 #endif 242 #endif
243 // Make sure tabCapture API can be granted for Chrome:// pages. 243 // Make sure tabCapture API can be granted for Chrome:// pages.
244 IN_PROC_BROWSER_TEST_F(TabCaptureApiTest, MAYBE_GrantForChromePages) { 244 IN_PROC_BROWSER_TEST_F(TabCaptureApiTest, MAYBE_GrantForChromePages) {
245 ExtensionTestMessageListener before_open_tab("ready1", true); 245 ExtensionTestMessageListener before_open_tab("ready1", true);
246 ASSERT_TRUE(RunExtensionSubtest("tab_capture", 246 ASSERT_TRUE(RunExtensionSubtest("tab_capture",
247 "active_tab_chrome_pages.html")) 247 "active_tab_chrome_pages.html"))
248 << message_; 248 << message_;
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 #endif 287 #endif
288 IN_PROC_BROWSER_TEST_F(TabCaptureApiTest, MAYBE_Constraints) { 288 IN_PROC_BROWSER_TEST_F(TabCaptureApiTest, MAYBE_Constraints) {
289 AddExtensionToCommandLineWhitelist(); 289 AddExtensionToCommandLineWhitelist();
290 ASSERT_TRUE(RunExtensionSubtest("tab_capture", "constraints.html")) 290 ASSERT_TRUE(RunExtensionSubtest("tab_capture", "constraints.html"))
291 << message_; 291 << message_;
292 } 292 }
293 293
294 } // namespace 294 } // namespace
295 295
296 } // namespace extensions 296 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698