Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: Source/core/html/HTMLFormControlsCollection.cpp

Issue 488703002: Make it obvious an HTMLFormControlsCollection can only contain HTMLElements (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormControlsCollection.cpp
diff --git a/Source/core/html/HTMLFormControlsCollection.cpp b/Source/core/html/HTMLFormControlsCollection.cpp
index d1e465334bd2af718bd265bb6ad7f23665cde37b..930381418114e59c812943a047e7c0f6cbf621a0 100644
--- a/Source/core/html/HTMLFormControlsCollection.cpp
+++ b/Source/core/html/HTMLFormControlsCollection.cpp
@@ -81,7 +81,7 @@ static unsigned findFormAssociatedElement(const FormAssociatedElement::List& ass
return i;
}
-Element* HTMLFormControlsCollection::virtualItemAfter(Element* previous) const
+HTMLElement* HTMLFormControlsCollection::virtualItemAfter(Element* previous) const
{
const FormAssociatedElement::List& associatedElements = formControlElements();
unsigned offset;
@@ -135,7 +135,7 @@ static HTMLElement* firstNamedItem(const FormAssociatedElement::List& elementsAr
return 0;
}
-Element* HTMLFormControlsCollection::namedItem(const AtomicString& name) const
+HTMLElement* HTMLFormControlsCollection::namedItem(const AtomicString& name) const
{
// http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/nameditem.asp
// This method first searches for an object with a matching id
@@ -219,7 +219,7 @@ void HTMLFormControlsCollection::supportedPropertyNames(Vector<String>& names)
HashSet<AtomicString> existingNames;
unsigned length = this->length();
for (unsigned i = 0; i < length; ++i) {
- Element* element = item(i);
+ HTMLElement* element = item(i);
ASSERT(element);
const AtomicString& idAttribute = element->getIdAttribute();
if (!idAttribute.isEmpty()) {
« no previous file with comments | « Source/core/html/HTMLFormControlsCollection.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698