Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 488643005: Fixes regression from changes to restore tabs (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixes regression from changes to restore tabs The code was assuming that if IDC_RESTORE_TAB returned true that the TabRestoreService had non-empty entries. This is no longer a valid assumpion. BUG=404407 TEST=see bug R=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290772

Patch Set 1 #

Total comments: 2

Patch Set 2 : better comment #

Patch Set 3 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/system_menu_model_delegate.cc View 1 2 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
sky
Clearly I need a test, but I'm going to do that separately as this is ...
6 years, 4 months ago (2014-08-19 19:36:30 UTC) #1
pkotwicz
LGTM https://codereview.chromium.org/488643005/diff/1/chrome/browser/ui/views/frame/system_menu_model_delegate.cc File chrome/browser/ui/views/frame/system_menu_model_delegate.cc (right): https://codereview.chromium.org/488643005/diff/1/chrome/browser/ui/views/frame/system_menu_model_delegate.cc#newcode48 chrome/browser/ui/views/frame/system_menu_model_delegate.cc:48: // the menu. Nit: chrome::IsCommandEnabled() returns true for ...
6 years, 4 months ago (2014-08-19 21:12:14 UTC) #2
sky
https://codereview.chromium.org/488643005/diff/1/chrome/browser/ui/views/frame/system_menu_model_delegate.cc File chrome/browser/ui/views/frame/system_menu_model_delegate.cc (right): https://codereview.chromium.org/488643005/diff/1/chrome/browser/ui/views/frame/system_menu_model_delegate.cc#newcode48 chrome/browser/ui/views/frame/system_menu_model_delegate.cc:48: // the menu. On 2014/08/19 21:12:14, pkotwicz wrote: > ...
6 years, 4 months ago (2014-08-19 21:35:08 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-19 21:35:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/488643005/20001
6 years, 4 months ago (2014-08-19 21:36:02 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 22:39:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 23:50:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/7437)
6 years, 4 months ago (2014-08-19 23:50:37 UTC) #8
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-20 01:09:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/488643005/40001
6 years, 4 months ago (2014-08-20 01:10:56 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 02:34:17 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 03:33:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/513)
6 years, 4 months ago (2014-08-20 03:33:23 UTC) #13
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-20 04:46:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/488643005/40001
6 years, 4 months ago (2014-08-20 04:47:11 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 05:56:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290772

Powered by Google App Engine
This is Rietveld 408576698