Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 48863002: Set the Swarm Test encoding to UTF-8 (Closed)

Created:
7 years, 1 month ago by csharp
Modified:
7 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org
Visibility:
Public.

Description

Set the Swarm Test encoding to UTF-8 By default Swarm assumes the encoding is ascii. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=231324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M swarming.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/swarming_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
csharp
7 years, 1 month ago (2013-10-28 14:14:46 UTC) #1
csharp
Note, this doesn't fix the Swarm exception, I just happen to notice it when looking ...
7 years, 1 month ago (2013-10-28 14:16:25 UTC) #2
M-A Ruel
lgtm
7 years, 1 month ago (2013-10-28 14:37:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/48863002/1
7 years, 1 month ago (2013-10-28 14:38:45 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 14:40:30 UTC) #5
Message was sent while issue was closed.
Change committed as 231324

Powered by Google App Engine
This is Rietveld 408576698