Issue 488593003: Make SpaceSplitStringData private and rename to Data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 488593003: Make SpaceSplitStringData private and rename to Data (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
adamk, rwlbuis

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make SpaceSplitStringData private and rename to Data Make SpaceSplitStringData private in the SpaceSplitString class as this is an implementation detail and there is no need to expose this class. This CL also renames SpaceSplitStringData to Data to avoid redundancy and fixes indentation in the header. R=adamk@chromium.org, rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180652

Patch Set 1 #

Patch Set 2 : Clean up #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -52 lines)			Patch
	M	Source/core/dom/SpaceSplitString.h	View		4 chunks	+36 lines, -33 lines	0 comments	Download
	M	Source/core/dom/SpaceSplitString.cpp	View	1	6 chunks	+17 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/488593003/20001

6 years, 4 months ago (2014-08-20 15:12:24 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-20 15:15:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180652

Expand Messages | Collapse Messages