Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 488593003: Make SpaceSplitStringData private and rename to Data (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk, rwlbuis
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Make SpaceSplitStringData private and rename to Data Make SpaceSplitStringData private in the SpaceSplitString class as this is an implementation detail and there is no need to expose this class. This CL also renames SpaceSplitStringData to Data to avoid redundancy and fixes indentation in the header. R=adamk@chromium.org, rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180652

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M Source/core/dom/SpaceSplitString.h View 4 chunks +36 lines, -33 lines 0 comments Download
M Source/core/dom/SpaceSplitString.cpp View 1 6 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 4 months ago (2014-08-19 14:44:28 UTC) #1
adamk
lgtm
6 years, 4 months ago (2014-08-19 23:34:23 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-20 15:11:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/488593003/20001
6 years, 4 months ago (2014-08-20 15:12:24 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 15:15:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180652

Powered by Google App Engine
This is Rietveld 408576698