Desktop user manager focuses correct pod on load.

Desktop user manager focuses correct pod on load.

BUG=404659
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290674

[dzhioev (left Google), 2014-08-19 11:52:04]

Hi, please take a look.

[noms (inactive), 2014-08-19 14:40:07]

https://codereview.chromium.org/488563002/diff/20001/ui/login/account_picker/...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/488563002/diff/20001/ui/login/account_picker/...
ui/login/account_picker/user_pod_row.js:2685: return this.pods[podIndex];
I would actually return null on the desktop if we haven't got a pod to focus
explicitly. 
This happens when 
a) Guest mode exists and the user manager comes up (there's no reason why we
should prefer a pod)
b) we're showing a tutorial, in which case we don't want to focus anything
anyway

[dzhioev (left Google), 2014-08-19 17:02:08]

On 2014/08/19 14:40:07, Monica Dinculescu wrote:
>
https://codereview.chromium.org/488563002/diff/20001/ui/login/account_picker/...
> File ui/login/account_picker/user_pod_row.js (right):
> 
>
https://codereview.chromium.org/488563002/diff/20001/ui/login/account_picker/...
> ui/login/account_picker/user_pod_row.js:2685: return this.pods[podIndex];
> I would actually return null on the desktop if we haven't got a pod to focus
> explicitly. 
> This happens when 
> a) Guest mode exists and the user manager comes up (there's no reason why we
> should prefer a pod)
> b) we're showing a tutorial, in which case we don't want to focus anything
> anyway

Done.

[noms (inactive), 2014-08-19 17:06:37]

lgtm. Thanks so much for fixing this! \o/

[dzhioev (left Google), 2014-08-19 17:12:38]

The CQ bit was checked by dzhioev@chromium.org

[commit-bot: I haz the power, 2014-08-19 17:14:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dzhioev@chromium.org/488563002/40001

[commit-bot: I haz the power, 2014-08-19 21:23:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-19 22:07:53]

Committed patchset #3 (40001) as 290674