Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/ui/webui/omnibox/omnibox.mojom

Issue 488533005: Mark all pointer fields in omnibox.mojom as nullable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/omnibox/omnibox.mojom
diff --git a/chrome/browser/ui/webui/omnibox/omnibox.mojom b/chrome/browser/ui/webui/omnibox/omnibox.mojom
index d7afd5d3bdedd1656ac36e3cf52e2d93f8a8bbd3..096c8a79a9e7e9d04cf69e3498693475382b202e 100644
--- a/chrome/browser/ui/webui/omnibox/omnibox.mojom
+++ b/chrome/browser/ui/webui/omnibox/omnibox.mojom
@@ -5,51 +5,51 @@
// The structures here roughly mirror those from autocomplete.
struct AutocompleteAdditionalInfo {
- string key;
- string value;
+ string? key;
+ string? value;
};
struct AutocompleteMatchMojo {
- string provider_name;
+ string? provider_name;
// Only meaningful if |provider_name| is valid.
bool provider_done;
int32 relevance;
bool deletable;
- string fill_into_edit;
- string inline_autocompletion;
- string destination_url;
- string contents;
- string description;
+ string? fill_into_edit;
+ string? inline_autocompletion;
+ string? destination_url;
+ string? contents;
+ string? description;
int32 transition;
bool is_history_what_you_typed_match;
bool allowed_to_be_default_match;
- string type;
- string associated_keyword;
- string keyword;
+ string? type;
+ string? associated_keyword;
+ string? keyword;
bool starred;
int32 duplicates;
bool from_previous;
- AutocompleteAdditionalInfo[] additional_info;
+ AutocompleteAdditionalInfo?[]? additional_info;
sky 2014/08/22 22:47:14 ll of these arrays may be NULL, but they shouldn't
};
struct AutocompleteResultsForProviderMojo {
- string provider_name;
- AutocompleteMatchMojo[] results;
+ string? provider_name;
+ AutocompleteMatchMojo?[]? results;
};
struct OmniboxResultMojo {
bool done;
// Time delta since the request was started, in milliseconds.
int32 time_since_omnibox_started_ms;
- string host;
+ string? host;
bool is_typed_host;
- AutocompleteMatchMojo[] combined_results;
- AutocompleteResultsForProviderMojo[] results_by_provider;
+ AutocompleteMatchMojo?[]? combined_results;
+ AutocompleteResultsForProviderMojo?[]? results_by_provider;
};
[Client=OmniboxPage]
interface OmniboxUIHandlerMojo {
- StartOmniboxQuery(string input_string,
+ StartOmniboxQuery(string? input_string,
int32 cursor_position,
bool prevent_inline_autocomplete,
bool prefer_keyword,
@@ -57,5 +57,5 @@ interface OmniboxUIHandlerMojo {
};
interface OmniboxPage {
- HandleNewAutocompleteResult(OmniboxResultMojo result);
+ HandleNewAutocompleteResult(OmniboxResultMojo? result);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698