Mark all pointer fields in omnibox.mojom as nullable.

Mark all pointer fields in omnibox.mojom as nullable.

There will be a follow-up CL to switch some fields to non-nullable.

BUG=406580
TEST=None

Committed: https://crrev.com/ce6c5546caf24780e28720e82b9b2de7ea49da48
Cr-Commit-Position: refs/heads/master@{#291591}

[yzshen1, 2014-08-22 22:46:06]

Hi, Scott.

Would you please take a look? Thanks!

[sky, 2014-08-22 22:47:14]

https://codereview.chromium.org/488533005/diff/1/chrome/browser/ui/webui/omni...
File chrome/browser/ui/webui/omnibox/omnibox.mojom (right):

https://codereview.chromium.org/488533005/diff/1/chrome/browser/ui/webui/omni...
chrome/browser/ui/webui/omnibox/omnibox.mojom:32: AutocompleteAdditionalInfo?[]?
additional_info;
ll of these arrays may be NULL, but they shouldn't contain NULLs themself. Does
that mean only one ? is needed?

[yzshen1, 2014-08-22 22:49:06]

On 2014/08/22 22:47:14, sky wrote:
>
https://codereview.chromium.org/488533005/diff/1/chrome/browser/ui/webui/omni...
> File chrome/browser/ui/webui/omnibox/omnibox.mojom (right):
> 
>
https://codereview.chromium.org/488533005/diff/1/chrome/browser/ui/webui/omni...
> chrome/browser/ui/webui/omnibox/omnibox.mojom:32:
AutocompleteAdditionalInfo?[]?
> additional_info;
> ll of these arrays may be NULL, but they shouldn't contain NULLs themself.
Does
> that mean only one ? is needed?

Yes. I just "blindly" marked everything to nullable so that they behave exactly
the same as before. I could remove all nullable flag for array elements.

[sky, 2014-08-22 22:50:54]

LGTM - ok, we'll clean it up in the next pass.

[yzshen1, 2014-08-22 22:51:09]

On 2014/08/22 22:49:06, yzshen1 wrote:
> On 2014/08/22 22:47:14, sky wrote:
> >
>
https://codereview.chromium.org/488533005/diff/1/chrome/browser/ui/webui/omni...
> > File chrome/browser/ui/webui/omnibox/omnibox.mojom (right):
> > 
> >
>
https://codereview.chromium.org/488533005/diff/1/chrome/browser/ui/webui/omni...
> > chrome/browser/ui/webui/omnibox/omnibox.mojom:32:
> AutocompleteAdditionalInfo?[]?
> > additional_info;
> > ll of these arrays may be NULL, but they shouldn't contain NULLs themself.
> Does
> > that mean only one ? is needed?
> 
> Yes. I just "blindly" marked everything to nullable so that they behave
exactly
> the same as before. I could remove all nullable flag for array elements.

Done. Removed those nullable flags for array elements.

[yzshen1, 2014-08-22 22:57:18]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2014-08-22 22:59:13]

On 2014/08/22 22:51:09, yzshen1 wrote:
> On 2014/08/22 22:49:06, yzshen1 wrote:
> > On 2014/08/22 22:47:14, sky wrote:
> > >
> >
>
https://codereview.chromium.org/488533005/diff/1/chrome/browser/ui/webui/omni...
> > > File chrome/browser/ui/webui/omnibox/omnibox.mojom (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/488533005/diff/1/chrome/browser/ui/webui/omni...
> > > chrome/browser/ui/webui/omnibox/omnibox.mojom:32:
> > AutocompleteAdditionalInfo?[]?
> > > additional_info;
> > > ll of these arrays may be NULL, but they shouldn't contain NULLs themself.
> > Does
> > > that mean only one ? is needed?
> > 
> > Yes. I just "blindly" marked everything to nullable so that they behave
> exactly
> > the same as before. I could remove all nullable flag for array elements.
> 
> Done. Removed those nullable flags for array elements.

I realize you LGed before I uploaded my newer patch. Then I will just land the
"all-nullable" patch (#1). Thanks, Scott. And sorry for all the inconvenience.

[commit-bot: I haz the power, 2014-08-22 22:59:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yzshen@chromium.org/488533005/1

[commit-bot: I haz the power, 2014-08-23 21:44:43]

Committed patchset #1 (1) as 783b98485dfb5d284cb6412b258ff408f6043a7f

[commit-bot: I haz the power, 2014-09-10 02:31:23]

Patchset 1 (id:??) landed as
https://crrev.com/ce6c5546caf24780e28720e82b9b2de7ea49da48
Cr-Commit-Position: refs/heads/master@{#291591}