Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 488533002: Add a test to verify the waveform from the Pepper MediaStream API is as (Closed)

Created:
6 years, 4 months ago by Anand Mistry (off Chromium)
Modified:
6 years, 3 months ago
Reviewers:
teravest
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mediastream-samples-fix
Project:
chromium
Visibility:
Public.

Description

Add a test to verify the waveform from the Pepper MediaStream API is as expected. BUG=405413 Committed: https://crrev.com/edf03bca7f54896c848d7b3a92f2c0078edede4b Cr-Commit-Position: refs/heads/master@{#296364}

Patch Set 1 #

Patch Set 2 : Rename variable. #

Patch Set 3 : Add missing includes. #

Patch Set 4 : Fix MSVC. #

Patch Set 5 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -2 lines) Patch
M ppapi/tests/test_media_stream_audio_track.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_media_stream_audio_track.cc View 1 2 3 5 chunks +138 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Anand Mistry (off Chromium)
6 years, 4 months ago (2014-08-19 23:33:55 UTC) #1
Anand Mistry (off Chromium)
6 years, 4 months ago (2014-08-19 23:34:19 UTC) #2
teravest
lgtm
6 years, 3 months ago (2014-09-19 19:49:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/488533002/80001
6 years, 3 months ago (2014-09-24 07:48:39 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001) as d4174a37c507fde365f7634af6eff58202519da6
6 years, 3 months ago (2014-09-24 07:53:25 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 07:54:01 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/edf03bca7f54896c848d7b3a92f2c0078edede4b
Cr-Commit-Position: refs/heads/master@{#296364}

Powered by Google App Engine
This is Rietveld 408576698