Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 48853005: Remove ExtensionToolbarModel from ExtensionService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile after rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
index 81ebc798f603f5f560c9bffe19675730b52fa0a6..7eaae895669b975b60c2318a5ae94664e1b04683 100644
--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
@@ -17,6 +17,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
#include "chrome/browser/extensions/extension_tab_util.h"
+#include "chrome/browser/extensions/extension_toolbar_model.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
@@ -118,10 +119,9 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, Basic) {
ui_test_utils::NavigateToURL(browser(),
test_server()->GetURL("files/extensions/test_file.txt"));
- ExtensionService* service = extensions::ExtensionSystem::Get(
- browser()->profile())->extension_service();
- service->toolbar_model()->ExecuteBrowserAction(
- extension, browser(), NULL, true);
+ ExtensionToolbarModel* toolbar_model = ExtensionToolbarModel::Get(
+ browser()->profile());
+ toolbar_model->ExecuteBrowserAction(extension, browser(), NULL, true);
ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
}
@@ -551,7 +551,9 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoDragging) {
// regular and incognito mode.
// ABC -> CAB
- service->toolbar_model()->MoveBrowserAction(extension_c, 0);
+ ExtensionToolbarModel* toolbar_model = ExtensionToolbarModel::Get(
+ browser()->profile());
+ toolbar_model->MoveBrowserAction(extension_c, 0);
EXPECT_EQ(kTooltipC, GetBrowserActionsBar().GetTooltip(0));
EXPECT_EQ(kTooltipA, GetBrowserActionsBar().GetTooltip(1));
@@ -561,7 +563,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoDragging) {
EXPECT_EQ(kTooltipA, incognito_bar.GetTooltip(1));
// CAB -> CBA
- service->toolbar_model()->MoveBrowserAction(extension_b, 1);
+ toolbar_model->MoveBrowserAction(extension_b, 1);
EXPECT_EQ(kTooltipC, GetBrowserActionsBar().GetTooltip(0));
EXPECT_EQ(kTooltipB, GetBrowserActionsBar().GetTooltip(1));
@@ -591,16 +593,14 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, IncognitoSplit) {
BrowserActionTestUtil(incognito_browser).NumberOfBrowserActions());
// A click in the regular profile should open a tab in the regular profile.
- ExtensionService* service = extensions::ExtensionSystem::Get(
- browser()->profile())->extension_service();
- service->toolbar_model()->ExecuteBrowserAction(
- extension, browser(), NULL, true);
+ ExtensionToolbarModel* toolbar_model = ExtensionToolbarModel::Get(
+ browser()->profile());
+ toolbar_model->ExecuteBrowserAction(extension, browser(), NULL, true);
ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
// A click in the incognito profile should open a tab in the
// incognito profile.
- service->toolbar_model()->ExecuteBrowserAction(
- extension, incognito_browser, NULL, true);
+ toolbar_model->ExecuteBrowserAction(extension, incognito_browser, NULL, true);
ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
}
@@ -623,8 +623,9 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, DISABLED_CloseBackgroundPage) {
content::NotificationService::AllSources());
// Click the browser action.
- extensions::ExtensionSystem::Get(browser()->profile())->extension_service()->
- toolbar_model()->ExecuteBrowserAction(extension, browser(), NULL, true);
+ ExtensionToolbarModel* toolbar_model = ExtensionToolbarModel::Get(
+ browser()->profile());
+ toolbar_model->ExecuteBrowserAction(extension, browser(), NULL, true);
// It can take a moment for the background page to actually get destroyed
// so we wait for the notification before checking that it's really gone

Powered by Google App Engine
This is Rietveld 408576698