Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

Issue 48853005: Remove ExtensionToolbarModel from ExtensionService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile after rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h" 5 #include "chrome/browser/ui/gtk/browser_actions_toolbar_gtk.h"
6 6
7 #include <gtk/gtk.h> 7 #include <gtk/gtk.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <utility> 10 #include <utility>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/bind.h" 13 #include "base/bind.h"
14 #include "base/i18n/rtl.h" 14 #include "base/i18n/rtl.h"
15 #include "base/message_loop/message_loop.h" 15 #include "base/message_loop/message_loop.h"
16 #include "base/strings/utf_string_conversions.h" 16 #include "base/strings/utf_string_conversions.h"
17 #include "chrome/browser/chrome_notification_types.h" 17 #include "chrome/browser/chrome_notification_types.h"
18 #include "chrome/browser/extensions/api/commands/command_service.h" 18 #include "chrome/browser/extensions/api/commands/command_service.h"
19 #include "chrome/browser/extensions/extension_action.h" 19 #include "chrome/browser/extensions/extension_action.h"
20 #include "chrome/browser/extensions/extension_action_icon_factory.h" 20 #include "chrome/browser/extensions/extension_action_icon_factory.h"
21 #include "chrome/browser/extensions/extension_action_manager.h" 21 #include "chrome/browser/extensions/extension_action_manager.h"
22 #include "chrome/browser/extensions/extension_context_menu_model.h" 22 #include "chrome/browser/extensions/extension_context_menu_model.h"
23 #include "chrome/browser/extensions/extension_service.h" 23 #include "chrome/browser/extensions/extension_service.h"
24 #include "chrome/browser/extensions/extension_system.h" 24 #include "chrome/browser/extensions/extension_system.h"
25 #include "chrome/browser/extensions/extension_toolbar_model.h"
25 #include "chrome/browser/extensions/extension_util.h" 26 #include "chrome/browser/extensions/extension_util.h"
26 #include "chrome/browser/profiles/profile.h" 27 #include "chrome/browser/profiles/profile.h"
27 #include "chrome/browser/sessions/session_tab_helper.h" 28 #include "chrome/browser/sessions/session_tab_helper.h"
28 #include "chrome/browser/ui/browser.h" 29 #include "chrome/browser/ui/browser.h"
29 #include "chrome/browser/ui/gtk/browser_window_gtk.h" 30 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
30 #include "chrome/browser/ui/gtk/custom_button.h" 31 #include "chrome/browser/ui/gtk/custom_button.h"
31 #include "chrome/browser/ui/gtk/extensions/extension_popup_gtk.h" 32 #include "chrome/browser/ui/gtk/extensions/extension_popup_gtk.h"
32 #include "chrome/browser/ui/gtk/gtk_chrome_button.h" 33 #include "chrome/browser/ui/gtk/gtk_chrome_button.h"
33 #include "chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.h" 34 #include "chrome/browser/ui/gtk/gtk_chrome_shrinkable_hbox.h"
34 #include "chrome/browser/ui/gtk/gtk_theme_service.h" 35 #include "chrome/browser/ui/gtk/gtk_theme_service.h"
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 theme_service_(GtkThemeService::GetFrom(browser->profile())), 496 theme_service_(GtkThemeService::GetFrom(browser->profile())),
496 model_(NULL), 497 model_(NULL),
497 hbox_(gtk_hbox_new(FALSE, 0)), 498 hbox_(gtk_hbox_new(FALSE, 0)),
498 button_hbox_(gtk_chrome_shrinkable_hbox_new(TRUE, FALSE, kButtonPadding)), 499 button_hbox_(gtk_chrome_shrinkable_hbox_new(TRUE, FALSE, kButtonPadding)),
499 drag_button_(NULL), 500 drag_button_(NULL),
500 drop_index_(-1), 501 drop_index_(-1),
501 resize_animation_(this), 502 resize_animation_(this),
502 desired_width_(0), 503 desired_width_(0),
503 start_width_(0), 504 start_width_(0),
504 weak_factory_(this) { 505 weak_factory_(this) {
505 ExtensionService* extension_service = 506 model_ = ExtensionToolbarModel::Get(profile_);
506 extensions::ExtensionSystem::Get(profile_)->extension_service(); 507 if (!model_)
507 if (!extension_service)
508 return; 508 return;
509 509
510 overflow_button_.reset(new CustomDrawButton( 510 overflow_button_.reset(new CustomDrawButton(
511 theme_service_, 511 theme_service_,
512 IDR_BROWSER_ACTIONS_OVERFLOW, 512 IDR_BROWSER_ACTIONS_OVERFLOW,
513 IDR_BROWSER_ACTIONS_OVERFLOW_P, 513 IDR_BROWSER_ACTIONS_OVERFLOW_P,
514 IDR_BROWSER_ACTIONS_OVERFLOW_H, 514 IDR_BROWSER_ACTIONS_OVERFLOW_H,
515 0, 515 0,
516 gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_NONE))); 516 gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_NONE)));
517 517
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 gtk_widget_set_no_show_all(separator_.get(), TRUE); 552 gtk_widget_set_no_show_all(separator_.get(), TRUE);
553 553
554 gtk_widget_show_all(overflow_area_.get()); 554 gtk_widget_show_all(overflow_area_.get());
555 gtk_widget_set_no_show_all(overflow_area_.get(), TRUE); 555 gtk_widget_set_no_show_all(overflow_area_.get(), TRUE);
556 556
557 gtk_box_pack_start(GTK_BOX(hbox_.get()), gripper, FALSE, FALSE, 0); 557 gtk_box_pack_start(GTK_BOX(hbox_.get()), gripper, FALSE, FALSE, 0);
558 gtk_box_pack_start(GTK_BOX(hbox_.get()), button_hbox_.get(), TRUE, TRUE, 0); 558 gtk_box_pack_start(GTK_BOX(hbox_.get()), button_hbox_.get(), TRUE, TRUE, 0);
559 gtk_box_pack_start(GTK_BOX(hbox_.get()), overflow_area_.get(), FALSE, FALSE, 559 gtk_box_pack_start(GTK_BOX(hbox_.get()), overflow_area_.get(), FALSE, FALSE,
560 0); 560 0);
561 561
562 model_ = extension_service->toolbar_model();
563 model_->AddObserver(this); 562 model_->AddObserver(this);
564 SetupDrags(); 563 SetupDrags();
565 564
566 if (model_->extensions_initialized()) { 565 if (model_->extensions_initialized()) {
567 CreateAllButtons(); 566 CreateAllButtons();
568 SetContainerWidth(); 567 SetContainerWidth();
569 } 568 }
570 569
571 // We want to connect to "set-focus" on the toplevel window; we have to wait 570 // We want to connect to "set-focus" on the toplevel window; we have to wait
572 // until we are added to a toplevel window to do so. 571 // until we are added to a toplevel window to do so.
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
1118 1117
1119 menu->PopupAsContext(gfx::Point(event->x_root, event->y_root), 1118 menu->PopupAsContext(gfx::Point(event->x_root, event->y_root),
1120 event->time); 1119 event->time);
1121 return TRUE; 1120 return TRUE;
1122 } 1121 }
1123 1122
1124 void BrowserActionsToolbarGtk::OnButtonShowOrHide(GtkWidget* sender) { 1123 void BrowserActionsToolbarGtk::OnButtonShowOrHide(GtkWidget* sender) {
1125 if (!resize_animation_.is_animating()) 1124 if (!resize_animation_.is_animating())
1126 UpdateChevronVisibility(); 1125 UpdateChevronVisibility();
1127 } 1126 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/views/browser_actions_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698