Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: chrome/browser/extensions/error_console/error_console_browsertest.cc

Issue 48853005: Remove ExtensionToolbarModel from ExtensionService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile after rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/error_console/error_console.h" 5 #include "chrome/browser/extensions/error_console/error_console.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "chrome/browser/extensions/extension_browsertest.h" 12 #include "chrome/browser/extensions/extension_browsertest.h"
13 #include "chrome/browser/extensions/extension_service.h"
14 #include "chrome/browser/extensions/extension_system.h"
15 #include "chrome/browser/extensions/extension_toolbar_model.h" 13 #include "chrome/browser/extensions/extension_toolbar_model.h"
16 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/common/extensions/extension.h" 15 #include "chrome/common/extensions/extension.h"
18 #include "chrome/common/extensions/feature_switch.h" 16 #include "chrome/common/extensions/feature_switch.h"
19 #include "chrome/common/pref_names.h" 17 #include "chrome/common/pref_names.h"
20 #include "chrome/test/base/ui_test_utils.h" 18 #include "chrome/test/base/ui_test_utils.h"
21 #include "extensions/browser/extension_error.h" 19 #include "extensions/browser/extension_error.h"
22 #include "extensions/common/constants.h" 20 #include "extensions/common/constants.h"
23 #include "extensions/common/error_utils.h" 21 #include "extensions/common/error_utils.h"
24 #include "extensions/common/extension_urls.h" 22 #include "extensions/common/extension_urls.h"
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 *extension = 235 *extension =
238 LoadExtensionWithFlags(test_data_dir_.AppendASCII(path), flags); 236 LoadExtensionWithFlags(test_data_dir_.AppendASCII(path), flags);
239 ASSERT_TRUE(*extension); 237 ASSERT_TRUE(*extension);
240 238
241 switch (action) { 239 switch (action) {
242 case ACTION_NAVIGATE: { 240 case ACTION_NAVIGATE: {
243 ui_test_utils::NavigateToURL(browser(), GetTestURL()); 241 ui_test_utils::NavigateToURL(browser(), GetTestURL());
244 break; 242 break;
245 } 243 }
246 case ACTION_BROWSER_ACTION: { 244 case ACTION_BROWSER_ACTION: {
247 ExtensionService* service = 245 ExtensionToolbarModel::Get(profile())->ExecuteBrowserAction(
248 extensions::ExtensionSystem::Get(profile())->extension_service();
249 service->toolbar_model()->ExecuteBrowserAction(
250 *extension, browser(), NULL, true); 246 *extension, browser(), NULL, true);
251 break; 247 break;
252 } 248 }
253 case ACTION_NONE: 249 case ACTION_NONE:
254 break; 250 break;
255 default: 251 default:
256 NOTREACHED(); 252 NOTREACHED();
257 } 253 }
258 254
259 observer.WaitForErrors(); 255 observer.WaitForErrors();
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 514
519 const StackTrace& stack_trace = GetStackTraceFromError(errors[0]); 515 const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
520 ASSERT_EQ(1u, stack_trace.size()); 516 ASSERT_EQ(1u, stack_trace.size());
521 CheckStackFrame(stack_trace[0], 517 CheckStackFrame(stack_trace[0],
522 script_url, 518 script_url,
523 kAnonymousFunction, 519 kAnonymousFunction,
524 5u, 1u); 520 5u, 1u);
525 } 521 }
526 522
527 } // namespace extensions 523 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698