Issue 488463004: Revert of Make GrGpuResources register with GrResourceCache2 after fully constructed.

Issue 488463004: Revert of Make GrGpuResources register with GrResourceCache2 after fully constructed. (Closed)

Created:
6 years, 3 months ago by bsalomon

Modified:
6 years, 3 months ago

Reviewers:
robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Make GrGpuResources register with GrResourceCache2 after fully constructed. (patchset #3 of https://codereview.chromium.org/504313002/) Reason for revert: Breaking the bots Original issue's description: > Make GrGpuResources register with GrResourceCache2 after fully constructed. > > Committed: https://skia.googlesource.com/skia/+/d68b3e491bb765beb7ca5e4ac8e0c80dedf5a83b TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/a2b0af82f02a74749b0ae8c315202a810a89bcb8

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -29 lines)			Patch
M	bench/GrResourceCacheBench.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	include/gpu/GrGpuResource.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/gpu/GrGpuResource.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/gpu/GrPathRange.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/GrResourceCache2.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/gpu/GrResourceCache2.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/gpu/GrStencilAndCoverTextContext.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLPath.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLRenderTarget.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLStencilBuffer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLTexture.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLVertexArray.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/ResourceCacheTest.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of Make GrGpuResources register with GrResourceCache2 after fully constructed.

6 years, 3 months ago (2014-08-26 20:09:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/488463004/1

6 years, 3 months ago (2014-08-26 20:10:56 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-08-26 20:11:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (1) as a2b0af82f02a74749b0ae8c315202a810a89bcb8